View Issue Details

IDProjectCategoryView StatusLast Update
0000929OpenMPTUser Interfacepublic2017-03-29 19:37
ReporterMidori Assigned ToSaga Musix  
PriorityhighSeveritymajorReproducibilityalways
Status assignedResolutionopen 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.26.09.00 / libopenmpt 0.2-beta22 (upgrade first) 
Summary0000929: Pattern selection mode lock-up after using SHIFT+ [KEY] combinations
Description

Setting Shift as modifier key for some actions can cause misbehavior of pattern selection.

In my case, I've assigned cycling through the pattern channels to the TAB (next channel) and SHIFT+TAB (previous channel). Normally, holding Shift itself causes MPT to enter the selection mode, so you can span the selection mark over the area of choice with arrow keys, but when i use it as a modifier key to obtain the actions defined above, not only the selection mode is activated, but it also locks up completely, so that releasing Shift doesn't disable it - playing the track right after hitting the combination shows that misbehavior clearly - selection starts spanning over the pattern from the cursor location while no keys are being held by the user.

Steps To Reproduce
  1. Set up some custom key mapping, which involves SHIFT + [ANY_KEY] combination
  2. Go to the pattern editor, make sure it has the focus and Follow Song mode is enabled
  3. Use the aforementioned custom key combo, release all keys
  4. Now the selection mark mode is in locked state. Try hitting the playback button - selection will start expanding starting from the last location of the cursor
Additional Information

For now tested only on Windows XP Professional 32bit SP3.
Happens only with Follow Song mode enabled.

TagsNo tags attached.
Has the bug occurred in previous versions?Not tested
Tested code revision (in case you know it)Build Date: Mar 19 2017 13:30:25

Activities

Saga Musix

Saga Musix

2017-03-27 22:29

administrator   ~0002940

Tab/Shift+Tab are actually default shortcuts and while they do conflict with shift-selections, I cannot reproduce the error your descibe - the selection keeps disappearing after Shift is released.

Midori

Midori

2017-03-28 15:50

reporter   ~0002942

I've tested the same thing on Windows 8.1 x64 today, and the problem persists for me. In attached video (available only for 24 hours) i've performed the channel switching twice, first attempt shows correct behavior, with my current mapping (TAB and CTRL+TAB for switching the channels forth and back, respectively).

Next, i've changed one of the bindings from CTRL+TAB to SHIFT+TAB, and tried to cycle between channels again, which resulted in the selection locking up again (can be clearly seen from 0000006:0000001:05 mark, when done while the track is playing, and view scrolls).

Interesting thing you might have noted, is that the dialog box, saying that the current combo is already mapped to some other action keeps popping up everytime when i'm changing this setting back to the SHIFT+TAB, even though i already confirmed removing the redundant mapping before recording the video.

I'm starting to have a sneaking suspicion that it's a conflict in my custom config, sitting somewhere, which i haven't managed to find yet (the keyboard mapping used on both OSes is the same one, imported from the exact same file)...

Video in question: https://a.uguu.se/B0p1J2n5I763_MPT_bug.mkv

Midori

Midori

2017-03-28 20:12

reporter   ~0002945

Added the keymap file for reference

Midori_keymapping.zip (5,572 bytes)
Saga Musix

Saga Musix

2017-03-28 20:29

administrator   ~0002946

Observation: Only happens if Shift+Tab was previously not assigned to this shortcut, and only happens until OpenMPT is closed.

Issue History

Date Modified Username Field Change
2017-03-27 19:11 Midori New Issue
2017-03-27 19:11 Midori Tag Attached: custom keys
2017-03-27 19:11 Midori Tag Attached: key mappings
2017-03-27 19:11 Midori Tag Attached: lock-up
2017-03-27 19:11 Midori Tag Attached: misbehavior
2017-03-27 19:11 Midori Tag Attached: misbehaviour
2017-03-27 19:11 Midori Tag Attached: selection
2017-03-27 19:11 Midori Tag Attached: selection mode
2017-03-27 19:11 Midori Tag Attached: SHIFT
2017-03-27 19:13 Midori Summary Pattern selection mode lock-up with certain unrelated SHIFT+ [KEY] combinations => Pattern selection mode lock-up after using SHIFT+ [KEY] combinations
2017-03-27 19:14 Midori Steps to Reproduce Updated View Revisions
2017-03-27 19:14 Midori Description Updated View Revisions
2017-03-27 22:29 Saga Musix Note Added: 0002940
2017-03-28 15:50 Midori Note Added: 0002942
2017-03-28 20:12 Midori File Added: Midori_keymapping.zip
2017-03-28 20:12 Midori Note Added: 0002945
2017-03-28 20:29 Saga Musix Note Added: 0002946
2017-03-29 15:26 Saga Musix Tag Detached: custom keys
2017-03-29 15:26 Saga Musix Tag Detached: key mappings
2017-03-29 15:26 Saga Musix Tag Detached: lock-up
2017-03-29 15:26 Saga Musix Tag Detached: misbehavior
2017-03-29 15:26 Saga Musix Tag Detached: misbehaviour
2017-03-29 15:26 Saga Musix Tag Detached: selection
2017-03-29 15:26 Saga Musix Tag Detached: selection mode
2017-03-29 15:26 Saga Musix Tag Detached: SHIFT
2017-03-29 19:37 Saga Musix Assigned To => Saga Musix
2017-03-29 19:37 Saga Musix Status new => assigned