View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000072 | OpenMPT | Playback Compatibility | public | 2011-02-15 00:43 | 2011-09-19 14:06 |
Reporter | 404notfound | Assigned To | Saga Musix | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | x86 | OS | Windows | OS Version | XP |
Product Version | OpenMPT 1.20.00.* (old testing) | ||||
Target Version | OpenMPT 1.20.01.00 (upgrade first) | Fixed in Version | OpenMPT 1.20.01.00 (upgrade first) | ||
Summary | 0000072: Global volume triggering before note-cut. | ||||
Description | Not sure if this is default Impulse Tracker behavior but note-cutting seems to trigger slightly after global volume changes. This is noticeable when bringing global volume from zero to full in the same row with note cuts. | ||||
Steps To Reproduce | With this particular tune: | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Has the bug occurred in previous versions? | Yes | ||||
Tested code revision (in case you know it) | |||||
I cannot notice any volume jumps there, but there is a good reason why they can happen in such a situation: Volume ramping. Global volume is applied on the mix buffer, so it is possible that the mixbuffer volume is reset while the cutted notes are still ramping out. |
|
I've tried various playback settings, and I can't reproduce this either. No pop or any kind of sound is coming from my speakers after the volume was down. I even turned up the volume as it was playing the patterns with WF1 in them. I see that you haven't entered a modplug tracker version. Can you confirm that this still happens in OpenMPT 1.19.03.00? Also, are you perhaps using ASIO4All or anything alike? |
|
Also, are you perhaps using ASIO4All or anything alike? All audio drivers receive the same audio data by OpenMPT, so this is not relevant. It would be more interesting to know which volume ramping settings are being used. |
|
I've uploaded the recording with the bug(and discovered another one while doing so). Also, using ompt stuff version(1.20.00.21). The bug can be heard both trough speakers and in wave writing so I guess it's not output dependent. |
|
Can you please provide us with a copy of your mptrack.ini? |
|
Yes, this is caused by your incredibly high ramping settings - try setting it to a normal value (42 samples) and the ramp-out should be far less noticeable - and as a side effect, your modules will sound a lot punchier and clearer. :) |
|
I've set ramping values to 42, 0 and even 1000. It still happens. |
|
Let's put it like this: At somewhat reasonable ramping levels (> 10 samples), the behaviour is expected: Global volume is being ramped up at the same time as samples are being ramped down. Since it is being done at the same time, there won't be total silence. You will have to live with that, since that's how ramping works. However, at very short ramping levels (< 10 samples), there seems to be an abnormally high sound burst, which should not happen. I'd consider that part a bug, but not the behaviour with higher ramping levels. |
|
Ok, it's pretty easy to explain why the burst happens with your configuration and not mine - you have Pro Logic Surround enabled, which adds a delayed signal. Since global volume is applied on the whole sound buffer, the delay is still audible when the global volume is up at full volume again. It might be possible (and even desireable) to apply global volume before applying effects, but for now (and also for the future) I'd recommend you to disable Pro Logic Surround anyway - especially when making your own music. It messed up mono signals like f.e. a bass drum that is panned to the center and will thus make the mix more muddy. |
|
Indeed it was the ProLogic Surround, although I guess using it all these years has spoiled me greatly. |
|
Oh, I also used it for years but I quickly got used to the lack of Pro Logic Surround after I disabled it for the reasons mentioned above. ;) |
|
Global volume processing happens before DSP processing in revision 1043. Please check http://sagagames.de/stuff/mptrack.exe (with Surround enabled) whether the problem remains. |
|
Fix confirmed. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2011-02-15 00:43 | 404notfound | New Issue | |
2011-02-15 00:43 | 404notfound | File Added: wfw-frth.zip | |
2011-02-15 23:15 | Saga Musix | Note Added: 0000068 | |
2011-02-15 23:16 | Saga Musix | Note Edited: 0000068 | |
2011-09-05 21:13 | LPChip | Note Added: 0000399 | |
2011-09-05 21:16 | Saga Musix | Note Added: 0000400 | |
2011-09-14 17:48 | 404notfound | File Added: wfw-frthpoopoo.zip | |
2011-09-14 17:52 | 404notfound | Note Added: 0000468 | |
2011-09-14 17:53 | 404notfound | Has the bug occurred in previous versions? | I think so. => Yes |
2011-09-14 17:53 | 404notfound | Product Version | => OpenMPT 1.20.00.* (old testing) |
2011-09-14 18:12 | Saga Musix | Note Added: 0000469 | |
2011-09-14 18:29 | 404notfound | File Added: mptrackini.zip | |
2011-09-17 21:43 | 404notfound | OS Version | 7 => XP |
2011-09-17 21:55 | Saga Musix | Note Added: 0000483 | |
2011-09-18 21:33 | 404notfound | Note Added: 0000488 | |
2011-09-18 21:45 | Saga Musix | Note Added: 0000489 | |
2011-09-18 21:55 | Saga Musix | Note Added: 0000490 | |
2011-09-18 21:57 | Saga Musix | Assigned To | => Saga Musix |
2011-09-18 21:57 | Saga Musix | Status | new => assigned |
2011-09-18 22:02 | 404notfound | Note Added: 0000491 | |
2011-09-18 22:03 | Saga Musix | Note Added: 0000492 | |
2011-09-18 22:09 | Saga Musix | File Deleted: mptrackini.zip | |
2011-09-18 23:49 | Saga Musix | Note Added: 0000493 | |
2011-09-18 23:49 | Saga Musix | Status | assigned => feedback |
2011-09-19 13:45 | 404notfound | Note Added: 0000495 | |
2011-09-19 13:45 | 404notfound | Status | feedback => assigned |
2011-09-19 14:06 | Saga Musix | Status | assigned => resolved |
2011-09-19 14:06 | Saga Musix | Resolution | open => fixed |
2011-09-19 14:06 | Saga Musix | Fixed in Version | => OpenMPT 1.20.00.* (old testing) |
2011-09-19 14:06 | Saga Musix | Target Version | => OpenMPT 1.20.01.00 (upgrade first) |