View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000244 | OpenMPT | Feature Request | public | 2012-05-06 17:08 | 2013-01-22 14:55 |
Reporter | harbinger | Assigned To | Saga Musix | ||
Priority | normal | Severity | feature | Reproducibility | N/A |
Status | resolved | Resolution | fixed | ||
Platform | x86 | OS | Windows | OS Version | XP |
Product Version | OpenMPT 1.20.01.* (old testing) | ||||
Target Version | OpenMPT 1.21.01.00 (upgrade first) | Fixed in Version | OpenMPT 1.21.01.00 (upgrade first) | ||
Summary | 0000244: Improvements in Sample Map dialog functionality | ||||
Description | In 1.20, you can click-and-drag the mouse across the keys in the Sample Map to select multiple notes for a sample. But we're a couple of features short of a perfect dialog box.
| ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | |||||
Tested code revision (in case you know it) | |||||
Regarding 1., what would be a justification for this rather arbitrary limitation? I think the most usual usage of the keyboard map is to "paint" whole regions of notes, f.e. to assign notes C-5 to C-6 to a given sample. Why should this assignment only apply to the white keys? Why should it need me to do two assignments (one for black and one for white) to accomplish this job? I honestly can't imagine of a situation where it would be an advantage to only paint over the black keys or only the white keys. Usually you wouldn't want to assign one sample to black keys and the other to white keys only. |
|
The main problem lies when one wants to assign ALL keys in a range (including black keys) but the user has accidentally not slid over all the keys -- such as along the bottom half where he has selected only the white keys. If he then attempts to go back over and slide across the black keys so those are included, it will, because of the nature of the graphic input, also DEselect the white keys. A Reset button would solve THIS more usual scenario (as long as previous assignments are not erased), but for those rare circumstances when you do want a sample to fill only the black keys in a range, dividing the keyboard input zones (or adjusting the keyboard "buttons") would allow for greater functionality. However, i myself would just be happy with a Reset button that reverts the assignments to what they were before editing the sample map. Or even better an Undo series for the duration of the dialog display... |
|
I don't think black vs white key separation is the solution to the problem. It would be more logical to make a mouse click not invert the current selection, but rather apply the same actions to all keys that are covered by the same mouse action. So if you click a key and assign a sample by clicking, dragging the mouse should assign the sample to all other hovered keys and not simply invert their state. |
|
Sounds good for a future build. Thanks. |
|
I have implemented the suggested behaviour from comment 0000244:0000720 now: http://sagagames.de/stuff/mptrack.exe |
|
Doesn't quite work. When clicking on an empty key, all keys you drag over will indeed turn them on, even if they're already on. When clicking on a key that's already set, the old behavior is called. Still half-broken. |
|
It's not really the old behaviour, it's just a "smart" behaviour that I intended to implement - apparently it's not as "smart" as I wanted it to be, though. This will have to be revised. |
|
Now everything should behave as intended. |
|
yes, but see 0000342 |
|
I'll close this then. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-05-06 17:08 | harbinger | New Issue | |
2012-05-09 23:28 | Saga Musix | Note Added: 0000716 | |
2012-05-10 12:49 | harbinger | Note Added: 0000717 | |
2012-05-10 13:01 | Saga Musix | Note Added: 0000720 | |
2012-05-14 13:22 | harbinger | Note Added: 0000726 | |
2012-07-04 00:21 | Saga Musix | Assigned To | => Saga Musix |
2012-07-04 00:21 | Saga Musix | Status | new => assigned |
2012-12-10 18:30 | Saga Musix | Note Added: 0000995 | |
2012-12-10 18:30 | Saga Musix | Note Edited: 0000995 | |
2012-12-10 18:31 | Saga Musix | Note Edited: 0000995 | |
2012-12-21 14:21 | harbinger | Note Added: 0001006 | |
2012-12-21 14:33 | Saga Musix | Note Added: 0001007 | |
2012-12-21 18:35 | Saga Musix | Note Added: 0001008 | |
2013-01-22 14:40 | harbinger | Note Added: 0001063 | |
2013-01-22 14:55 | Saga Musix | Note Edited: 0001063 | |
2013-01-22 14:55 | Saga Musix | Note Added: 0001066 | |
2013-01-22 14:55 | Saga Musix | Status | assigned => resolved |
2013-01-22 14:55 | Saga Musix | Resolution | open => fixed |
2013-01-22 14:55 | Saga Musix | Fixed in Version | => OpenMPT 1.21.01.00 (upgrade first) |
2013-01-22 14:55 | Saga Musix | Target Version | => OpenMPT 1.21.01.00 (upgrade first) |