View Issue Details

IDProjectCategoryView StatusLast Update
0001758OpenMPTFeature Requestpublic2024-10-26 23:59
ReporterSoDa7 Assigned ToSaga Musix  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Target VersionOpenMPT 1.32 / libopenmpt 0.8 (goals)Fixed in VersionOpenMPT 1.32 / libopenmpt 0.8 (goals) 
Summary0001758: Samplename editor with fixed fonts
Description

Hello. I would like to request a feature that allows modifying the sample names using a fixed-width font text editor (similar to those used by ASCII/ANSI artists), including a 'ruler' to display the number of characters used.

The reason is that sometimes I like to 'justify' the comments inside ProTracker modules, or even add some small ASCII art to them.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2024-03-22 17:33

administrator   ~0005878

I have a feeling this might be more useful in the Comments tab, where you can see the sample names in context. You can also edit them there by pressing Ctrl+Enter so you wouldn't have to go back and forth between the sample and comments tabs.

SoDa7

SoDa7

2024-04-03 18:07

reporter   ~0005908

I tried and seems like it doesn't work. I mean, I get the edit sample cursor but I can't write or delete anything

Saga Musix

Saga Musix

2024-04-03 18:07

administrator   ~0005909

Last edited: 2024-04-03 18:09

Whoops, something broke there indeed (probably when direct instrument preview from comments tab was implemented). Thanks for reporting!

Saga Musix

Saga Musix

2024-04-09 18:06

administrator   ~0005925

As a start, r20545 updates the font used in the sample and instrument lists in the comments tab to be the same as the comments font (so Courier New by default).

There are a few limitations: Label editing will switch back to the "normal" font. I could have used the same font there, but in that case Windows gets confused when measuring how big the input field will be, so some characters will be cut off. As this destroys the purpose of being able to carefully align those characters with surrounding ASCII art, I thought that it would not be very sensible to use the font there. Instead, the standard font is used but at least you get to see the entire sample name.

Updated test builds can be found within a few hours from https://builds.openmpt.org/builds/ - let me know how this works for you.

Saga Musix

Saga Musix

2024-04-09 18:13

administrator   ~0005926

fixed font.png (36,479 bytes)   
fixed font.png (36,479 bytes)   
Saga Musix

Saga Musix

2024-10-26 23:59

administrator   ~0006152

In addition to these improvements, the latest test builds (r21980 and later) now also have an option to paste a pre-formatted text into the sample list on the Comments Tab. This would allow you to design ASCII art in a proper text editor and then just paste the final result into OpenMPT. I think this is a lot more sensible than further modifying the sample editor, where you only see a single sample name anyway, so a ruler doesn't really help a lot with drawing.

Issue History

Date Modified Username Field Change
2024-03-22 16:44 SoDa7 New Issue
2024-03-22 17:33 Saga Musix Note Added: 0005878
2024-04-03 18:07 SoDa7 Note Added: 0005908
2024-04-03 18:07 Saga Musix Note Added: 0005909
2024-04-03 18:09 Saga Musix Note Edited: 0005909
2024-04-09 17:01 Saga Musix Assigned To => Saga Musix
2024-04-09 17:01 Saga Musix Status new => assigned
2024-04-09 18:06 Saga Musix Status assigned => feedback
2024-04-09 18:06 Saga Musix Note Added: 0005925
2024-04-09 18:06 Saga Musix Target Version => OpenMPT 1.32 / libopenmpt 0.8 (goals)
2024-04-09 18:13 Saga Musix Note Added: 0005926
2024-04-09 18:13 Saga Musix File Added: fixed font.png
2024-10-26 23:59 Saga Musix Note Added: 0006152
2024-10-26 23:59 Saga Musix Status feedback => resolved
2024-10-26 23:59 Saga Musix Resolution open => fixed
2024-10-26 23:59 Saga Musix Fixed in Version => OpenMPT 1.32 / libopenmpt 0.8 (goals)