View Issue Details

IDProjectCategoryView StatusLast Update
0001658OpenMPTUser Interfacepublic2023-01-30 08:07
ReporterSaga Musix Assigned To 
Status newResolutionopen 
Summary0001658: Find an alternative way to filter soundfont instruments

In 0001650, the short-lived instrument filter for soundfonts (introduced in 0001566) had to be removed again: With lots of active tree view nodes, there is an issue with the tree view (at in Windows Vista and newer) that causes the complete program to freeze when deleting some expanded tree view nodes or when trying to programmatically expand some nodes. While the latter could have been avoided (leading to worse user experience), the former cannot be avoided as we have to remove nodes during filtering for obvious reasons.

Theoretically there is one more possibility: Forcing the tree view to use the older common controls version that doesn't produce the freeze ( The tree view would look different, and there might be other unknown side effects.

So the only proper solution might be to completely re-think how to filter soundfonts: Preferably this would happen outside of the tree view, independently from the instrument library filter. Maybe a new window would open, just showing soundfont search results.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)


related to 0001650 resolvedSaga Musix Freeze when updating soundfont search filter 
related to 0001566 resolvedSaga Musix Sample & sound font list search 




2023-01-30 02:07

reporter   ~0005521

I have always thought of the present tree view as more functional than pretty, so I personally wouldnt be nostalgic for it if it were replaced by an older more stable form. I went to your link, but unfortunately there wasnt any screenshot of what those older trees look like or how they function compared to the one we use, but if it comes down to a simple case of aesthetics, I personally think it is worth the sacrifice. But obviously that would be something everyone would have to agree on - because now something like a search feature would be redesigning the look of ompt - even if it has always been a function rather than form part of ompt.
As for the second idea of a separate window - that sounds great too, as long as we can preview the sounds, and drag them from the new window into sample or instrument places, that sounds just as useful as the original proposition.
It would be nice to have this ready for the next version of ompt, a bit of a "we have this great new feature in the update" thing, but yeah I think it would be far more important to keep ompt working properly and staying stable no matter what is thrown at it.
One final thought... I dont think the sample part of the search was freezing anything at all - and the original form of the search worked fine by greying out the soundfonts that didnt have results. It took longer to find the soundfont results over all, but you could still find them and go through them. As lovely and quick as it was to have ompt temporarily get rid of the non result soundfonts, just having the original version until you can come up with a method you are more confident in would be awesome.
In the end of the day, something like this search is something that will probably be refined and changed a lot over the years anyways, so I think this is something to experiment on.

Saga Musix

Saga Musix

2023-01-30 08:07

administrator   ~0005522

just having the original version until you can come up with a method you are more confident in would be awesome.

No, that variant froze as well. Any variant that preserves how soundfonts are currently represented in the treeview will induce this sort of freeze.

It would be nice to have this ready for the next version of ompt


Issue History

Date Modified Username Field Change
2023-01-28 18:32 Saga Musix New Issue
2023-01-28 18:32 Saga Musix Relationship added related to 0001650
2023-01-28 18:32 Saga Musix Relationship added related to 0001566
2023-01-30 02:07 Exhale Note Added: 0005521
2023-01-30 08:07 Saga Musix Note Added: 0005522