View Issue Details

IDProjectCategoryView StatusLast Update
0001619OpenMPTFeature Requestpublic2023-03-20 20:27
Reporterelvisish Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Target VersionOpenMPT 1.31.01.00 / libopenmpt 0.7.0 (upgrade first)Fixed in VersionOpenMPT 1.31.01.00 / libopenmpt 0.7.0 (upgrade first) 
Summary0001619: Play/Stop from position keyboard shortcut
Description

A way of setting up a shortcut to toggle between play and stop, but return to the starting position it was at. Play/pause and play/stop returning to the beginning are currently possible, but not stopped and starting from the same point.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Relationships

has duplicate 0000931 closed Add play from cursor/stop command 

Activities

Saga Musix

Saga Musix

2022-09-25 17:11

administrator   ~0005321

Implemented in r17975 and backported to OpenMPT 1.30 in r17976.

elvisish

elvisish

2023-03-13 20:20

reporter   ~0005585

Is it possible to restart from the cursor as described in the issue with the new Play/Stop Song keyboard shortcut? This new keyboard shortcut seems to stop the song and resume from the start of it, rather from the starting cursor position.

Saga Musix

Saga Musix

2023-03-13 20:23

administrator   ~0005586

Now I'm confused. What you are describing now is exactly what Play / Pause does, isn't it?

elvisish

elvisish

2023-03-13 20:53

reporter   ~0005587

Play/Stop is great, but when pressed to start playback again, is it not possible to go back to the previous start position instead of the start of the song? I'm not sure if OpenMPT has the ability to start from a position or if the cursor always moves with the song playback.

elvisish

elvisish

2023-03-13 22:28

reporter   ~0005588

Yeah, what I'm trying to do is Play/Stop, but then when pressing play the next time I need to play from the cursor, not the start of the song (which is what Play/Stop does) or where the playback got to (which is what Play/Pause does)

Saga Musix

Saga Musix

2023-03-14 13:34

administrator   ~0005594

Okay, so... "Stop" always means "playback restarts from start of song", "Pause" means "playback restarts wherever it was paused". Hence the complete misunderstanding in the original implementation.

Just to clarify, so that I don't implement the wrong shortcut again: What you are looking for is a combination of the two shortcuts "Pause" and "Play song from cursor" into one shortcut?

elvisish

elvisish

2023-03-14 16:47

reporter   ~0005596

okay, so going from the start is definitely not what I'm doing, and Pause only goes from where it was stopped, which is also not where I'm trying to go from. I think I'm definitely looking for a Play Song from Cursor/Stop Song in the same button, so I can start and stop with the same key, but go from where the cursor is (not where it paused).

elvisish

elvisish

2023-03-18 20:33

reporter   ~0005609

So, could it be possible to add Play Song from Cursor/Stop Song? Currently I'm having to hold down Space to play the song and release it to work, it would be perfect if it could be stopped and played from cursor with the same key.

Saga Musix

Saga Musix

2023-03-18 22:38

administrator   ~0005610

There's two new shortcuts as of r18885: Play Song from Cursor / Pause and Play Song from Pattern Start / Pause (the latter mostly exists to complement the existing shortcuts so that it's not the odd one out). You will be able to download a test build from https://builds.openmpt.org/builds/ in a few hours, or by setting the update channel in OpenMPT to "Development". Let me know how it works for you.

elvisish

elvisish

2023-03-19 16:09

reporter   ~0005611

Last edited: 2023-03-19 16:14

Just found Follow Song which allows me to keep the cursor in the same position, thank you SO much for this keyboard shortcut, it's perfect!

Saga Musix

Saga Musix

2023-03-19 16:10

administrator   ~0005612

Uncheck the "Follow Song" checkbox in the pattern editor?

elvisish

elvisish

2023-03-19 16:15

reporter   ~0005613

Sorry I didn't realized you'd replied! Just wanted to say again how much I appreciate this, really has improved functionality for me!

elvisish

elvisish

2023-03-19 16:19

reporter   ~0005614

Strangely, if I enter a note into the pattern, I have to press the key twice to play? Is it somehow locking the shortcut if a note is entered?

Saga Musix

Saga Musix

2023-03-19 16:22

administrator   ~0005615

When you enter a note, playback is resumed for note preview (but the module is in step mode). So pressing the shortcut the first time will pause the module, second time will continue regular playback. This is how pause/step mode works in general in OpenMPT. While this behaviour could be changed specifically for those newly added shortcuts, I'm not sure if deviating from the known behaviour patterns is such a good idea.

elvisish

elvisish

2023-03-19 16:28

reporter   ~0005617

Last edited: 2023-03-19 16:29

It's a little bit unusual to press the shortcut to pause when it's playing, enter a note, then have to press the shortcut once and have nothing play then again to actually get it to play. Even if it is deviating from the known behavior, it would bring the functionality more in line with how it would be expected to work?

Also, could a shortcut to allow Play Song From Cursor/Stop have this work as expected?

Saga Musix

Saga Musix

2023-03-19 19:21

administrator   ~0005618

I just double-checked and the existing Play/Pause shortcut actually does take step mode into account. So I have modified the two newly added shortcuts accordingly in r18906. Updates will again be available in a few hours.

elvisish

elvisish

2023-03-19 21:31

reporter   ~0005620

That seems to work perfectly so far, thank you again!

Saga Musix

Saga Musix

2023-03-19 21:40

administrator   ~0005621

Good to hear. I won't backport these new shortcuts to the next OpenMPT 1.30 update, but OpenMPT 1.31 is around the corner. You can stay on the development channel until OpenMPT 1.31 is officially released.

Issue History

Date Modified Username Field Change
2022-07-30 22:54 elvisish New Issue
2022-09-25 17:08 Saga Musix Assigned To => Saga Musix
2022-09-25 17:08 Saga Musix Status new => assigned
2022-09-25 17:11 Saga Musix Fixed in Version => OpenMPT 1.30.08.00 / libopenmpt 0.6.6 (upgrade first)
2022-09-25 17:11 Saga Musix Target Version => OpenMPT 1.30.08.00 / libopenmpt 0.6.6 (upgrade first)
2022-09-25 17:11 Saga Musix Note Added: 0005321
2022-09-25 17:11 Saga Musix Status assigned => resolved
2022-09-25 17:11 Saga Musix Resolution open => fixed
2023-03-13 20:20 elvisish Status resolved => feedback
2023-03-13 20:20 elvisish Resolution fixed => reopened
2023-03-13 20:20 elvisish Note Added: 0005585
2023-03-13 20:23 Saga Musix Note Added: 0005586
2023-03-13 20:53 elvisish Note Added: 0005587
2023-03-13 20:53 elvisish Status feedback => assigned
2023-03-13 22:28 elvisish Note Added: 0005588
2023-03-14 13:34 Saga Musix Note Added: 0005594
2023-03-14 16:47 elvisish Note Added: 0005596
2023-03-18 20:33 elvisish Note Added: 0005609
2023-03-18 22:38 Saga Musix Note Added: 0005610
2023-03-18 22:38 Saga Musix Status assigned => feedback
2023-03-19 16:09 elvisish Note Added: 0005611
2023-03-19 16:09 elvisish Status feedback => assigned
2023-03-19 16:10 Saga Musix Note Added: 0005612
2023-03-19 16:10 Saga Musix Status assigned => feedback
2023-03-19 16:14 elvisish Note Edited: 0005611
2023-03-19 16:15 elvisish Note Added: 0005613
2023-03-19 16:15 elvisish Status feedback => assigned
2023-03-19 16:19 elvisish Note Added: 0005614
2023-03-19 16:22 Saga Musix Note Added: 0005615
2023-03-19 16:28 elvisish Note Added: 0005617
2023-03-19 16:29 elvisish Note Edited: 0005617
2023-03-19 19:21 Saga Musix Note Added: 0005618
2023-03-19 19:21 Saga Musix Status assigned => feedback
2023-03-19 21:31 elvisish Note Added: 0005620
2023-03-19 21:31 elvisish Status feedback => assigned
2023-03-19 21:40 Saga Musix Status assigned => resolved
2023-03-19 21:40 Saga Musix Fixed in Version OpenMPT 1.30.08.00 / libopenmpt 0.6.6 (upgrade first) => OpenMPT 1.31.01.00 / libopenmpt 0.7.0 (upgrade first)
2023-03-19 21:40 Saga Musix Target Version OpenMPT 1.30.08.00 / libopenmpt 0.6.6 (upgrade first) => OpenMPT 1.31.01.00 / libopenmpt 0.7.0 (upgrade first)
2023-03-19 21:40 Saga Musix Note Added: 0005621
2023-03-19 21:40 Saga Musix Resolution reopened => fixed
2023-03-20 20:27 Saga Musix Relationship added has duplicate 0000931