Implemented in r17975 and backported to OpenMPT 1.30 in r17976.

Is it possible to restart from the cursor as described in the issue with the new Play/Stop Song keyboard shortcut? This new keyboard shortcut seems to stop the song and resume from the start of it, rather from the starting cursor position.

Now I'm confused. What you are describing now is exactly what Play / Pause does, isn't it?

Play/Stop is great, but when pressed to start playback again, is it not possible to go back to the previous start position instead of the start of the song? I'm not sure if OpenMPT has the ability to start from a position or if the cursor always moves with the song playback.

Yeah, what I'm trying to do is Play/Stop, but then when pressing play the next time I need to play from the cursor, not the start of the song (which is what Play/Stop does) or where the playback got to (which is what Play/Pause does)

Okay, so... "Stop" always means "playback restarts from start of song", "Pause" means "playback restarts wherever it was paused". Hence the complete misunderstanding in the original implementation.

Just to clarify, so that I don't implement the wrong shortcut again: What you are looking for is a combination of the two shortcuts "Pause" and "Play song from cursor" into one shortcut?

okay, so going from the start is definitely not what I'm doing, and Pause only goes from where it was stopped, which is also not where I'm trying to go from. I think I'm definitely looking for a Play Song from Cursor/Stop Song in the same button, so I can start and stop with the same key, but go from where the cursor is (not where it paused).

So, could it be possible to add Play Song from Cursor/Stop Song? Currently I'm having to hold down Space to play the song and release it to work, it would be perfect if it could be stopped and played from cursor with the same key.

There's two new shortcuts as of r18885: Play Song from Cursor / Pause and Play Song from Pattern Start / Pause (the latter mostly exists to complement the existing shortcuts so that it's not the odd one out). You will be able to download a test build from https://builds.openmpt.org/builds/ in a few hours, or by setting the update channel in OpenMPT to "Development". Let me know how it works for you.

Just found Follow Song which allows me to keep the cursor in the same position, thank you SO much for this keyboard shortcut, it's perfect!

Uncheck the "Follow Song" checkbox in the pattern editor?

Sorry I didn't realized you'd replied! Just wanted to say again how much I appreciate this, really has improved functionality for me!

Strangely, if I enter a note into the pattern, I have to press the key twice to play? Is it somehow locking the shortcut if a note is entered?

When you enter a note, playback is resumed for note preview (but the module is in step mode). So pressing the shortcut the first time will pause the module, second time will continue regular playback. This is how pause/step mode works in general in OpenMPT. While this behaviour could be changed specifically for those newly added shortcuts, I'm not sure if deviating from the known behaviour patterns is such a good idea.

It's a little bit unusual to press the shortcut to pause when it's playing, enter a note, then have to press the shortcut once and have nothing play then again to actually get it to play. Even if it is deviating from the known behavior, it would bring the functionality more in line with how it would be expected to work?

Also, could a shortcut to allow Play Song From Cursor/Stop have this work as expected?

I just double-checked and the existing Play/Pause shortcut actually does take step mode into account. So I have modified the two newly added shortcuts accordingly in r18906. Updates will again be available in a few hours.

That seems to work perfectly so far, thank you again!

Good to hear. I won't backport these new shortcuts to the next OpenMPT 1.30 update, but OpenMPT 1.31 is around the corner. You can stay on the development channel until OpenMPT 1.31 is officially released.