View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001486OpenMPTUser Interfacepublic2021-08-11 21:542021-08-15 21:42
ReporterSaga Musix Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.29.11.00 / libopenmpt 0.5.10 (upgrade first) 
Target VersionOpenMPT 1.29.12.00 / libopenmpt 0.5.11 (upgrade first)Fixed in VersionOpenMPT 1.29.12.00 / libopenmpt 0.5.11 (upgrade first) 
Summary0001486: Find&Replace glitches with Sxy sub-commands
Description

Two scenarios that don't work properly:

  • Find: Command SC
  • Replace with: Command SC, Param 5

Replaces with SD5 instead of SC5

  • Find: Command SC
  • Replace with: Uncheck the checkbox next to Command SC, still replace with Param 5

In this case, the resulting command in SCF instead of SC5. If the replace-by command is not an SCx subcommand it works as intended (even though this should obviously not make a difference, because the relevant checkbox is checked)

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

StarWolf3000

StarWolf3000

2021-08-12 11:56

reporter   ~0004841

Find & Replace doesn't seem to properly work in this case with ANY Sxy command in S3M/IT/MPTM and Exy in MOD/XM and Xxy in XM:

I tried it out with placing all Sxy commands into empty cells and tried a Find & Replace with just the Effect on the "Find" and only the Effect Data on the "Replace". The result: Regardless of what you enter in the Effect Data, it always gets replaced by F (example: see attached image collage).

I also did try it with Exy and Xxy for the MOD and XM formats, with the same results, getting the Effect Data replaced with F, regardless of what was entered/selected.

ompt_find_replace_sxy_commands.png (27,692 bytes)   
ompt_find_replace_sxy_commands.png (27,692 bytes)   
Saga Musix

Saga Musix

2021-08-12 18:04

administrator   ~0004842

Yes, I should maybe have mentioned that those are just examples to quickly try it out - there is no special handling of the individual sub-commands, they all run through the same code so the failure mode is always the same too. They're really messy to handle sadly.
Saga Musix

Saga Musix

2021-08-15 21:36

administrator   ~0004844

Last edited: 2021-08-15 21:42

Hopefully more intuitive as of r15537.

Issue History

Date Modified Username Field Change
2021-08-11 21:54 Saga Musix New Issue
2021-08-12 11:56 StarWolf3000 Note Added: 0004841
2021-08-12 11:56 StarWolf3000 File Added: ompt_find_replace_sxy_commands.png
2021-08-12 18:04 Saga Musix Note Added: 0004842
2021-08-12 18:04 Saga Musix Assigned To => Saga Musix
2021-08-12 18:04 Saga Musix Status new => assigned
2021-08-15 21:36 Saga Musix Note Added: 0004844
2021-08-15 21:36 Saga Musix Status assigned => resolved
2021-08-15 21:36 Saga Musix Resolution open => fixed
2021-08-15 21:36 Saga Musix Fixed in Version => OpenMPT 1.29.12.00 / libopenmpt 0.5.11 (upgrade first)
2021-08-15 21:36 Saga Musix Target Version => OpenMPT 1.29.12.00 / libopenmpt 0.5.11 (upgrade first)
2021-08-15 21:42 Saga Musix Note Edited: 0004844