View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000910||OpenMPT||[All Projects] General||public||2017-01-11 03:23||2017-01-14 22:05|
|Target Version||Fixed in Version|
|Summary||0000910: Sometimes Crashes When Loading Samples|
I have noticed that OpenMPT sometimes crashes when attempting to load samples.
I have attached the crash dump for you. I hope that it is useful.
|Tags||No tags attached.|
|Has the bug occurred in previous versions?|
|Tested code revision (in case you know it)|
crash.zip (23,637 bytes)
As always, I need to know the exact code revision you used, and in case you compiled it yourself, the mptrack.exe/mptrack.pdb files; and preferrably also the sample the problem happened with.
The crash seems to happen in the file dialog (on Windows' side, not ours) with a null pointer, which might imply an out-of-memory situation. Do you have "Preview samples / instruments in file browser" enabled?Does it happen with samples of any size (especially smaller ones)? Does it also happen if you drag-and-drop the samples into the sample editor rather than loading them through the file dialog?
Crash signature seems to be identical to this Mozilla report: https://bugzilla.mozilla.org/show_bug.cgi?id=1324180
I am guessing that you are referring to the preview pane. Yes, I do have that enabled.
I am not sure. It might happen with those. I looked through some other crashes. But, I didn't see any clues as to what samples might have caused the crashes.
I have not tried that. Because I have OpenMPT's window restored up / maximized (I am not sure exactly what the difference is between "Maximize" and "restore up." I know that the common term used is "maximize." But, I also happen to know that they are differentiated within Windows' sound scheme.) and Windows Explorer's window restored down / minimized, that should not be a big deal to get used to doing that (at least, until such a time as the bug that causes the crash is fixed).
It is nice to see that the issue is unrelated to your code. It probably still doesn't hurt to update my revision, though.
No, I am referring to the option with this exact name found in the options dialog. I do not know what the "Preview Pane" is supposed to be.
Then do find it out.
I didn't want to hear an explanation why you didn't do it like that in the past, I want you to try it now to confirm if the problem does not happen that way.
I have tested that and did not see any crashes.
I looked at the advanced settings and found an option named PreviewInFileDialogs under a heading named Sample Editor. It is disabled.
I tested 23 samples (of varying sizes) and detected no crashes. I am also using revision 7518 now.
What is this "Preview Pane" then? Is that a Windows option to preview files? If so, disable that to see if it makes a difference.
Yes. It is handy for looking at pictures.
It might. I reproduced the problem twice. But, in an attempt to reproduce it a third time, I was unsuccessful. That is why there are no reproduction steps provided. I started making the list; but, I stopped because I was unable to reproduce the problem again. But, it involved these samples: https://drive.google.com/open?id=0BwzzNTe3LlQldGNtcUxzSUtkREU
|2017-01-11 03:23||Wodd||New Issue|
|2017-01-11 03:23||Wodd||File Added: crash.zip|
|2017-01-11 13:29||Saga Musix||Note Added: 0002834|
|2017-01-12 06:06||Wodd||Note Added: 0002836|
|2017-01-12 13:25||Saga Musix||Note Added: 0002837|
|2017-01-12 13:30||Saga Musix||Note Added: 0002838|
|2017-01-12 13:30||Saga Musix||Note Edited: 0002838||View Revisions|
|2017-01-12 13:40||Saga Musix||Note Edited: 0002837||View Revisions|
|2017-01-13 01:57||Wodd||Note Added: 0002841|
|2017-01-13 12:38||Saga Musix||Note Added: 0002842|
|2017-01-14 03:17||Wodd||Note Added: 0002845|
|2017-01-14 13:22||Saga Musix||Note Added: 0002846|
|2017-01-14 22:05||Wodd||Note Added: 0002848|