View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000861 | OpenMPT | General | public | 2016-08-12 14:33 | 2017-02-12 14:46 |
Reporter | manx | Assigned To | Saga Musix | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | no change required | ||
Product Version | OpenMPT 1.27.00.* (old testing) | ||||
Summary | 0000861: PortMIDI is incompatible with UNICODE | ||||
Description | The solution is to either fix PortMIDI, or use something else like either directly midiInFoo/midiOutFoo or RtMidi. | ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | |||||
Tested code revision (in case you know it) | |||||
Concerning RtMidi: They apparently have a (statically defined) maximum length for SysEx messages (1024 bytes), which I find potentially dangerous and questionable - OpenMPT itself cannot currently make use of such long messages, but VST could. |
|
So, RtMidi uses:
and PortMidi uses (portmidi.c and pmwinmm.c, we enter that code with bufferSize==0):
So, yes, the constants and overall buffering strategy is a little different, but not fundamentally so. AFAIK a fixed limit (which has to be set upfront) is kind of imposed by winmm anyway - but I have not done any WINAPI MIDI in years, let alone sysex handling, so I might be wrong here. |
|
Closing this as we got rid of PortMidi entirely, so there is nothing to fix anymore. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-08-12 14:33 | manx | New Issue | |
2016-08-12 14:33 | manx | Relationship added | child of 0000570 |
2016-08-12 19:11 | Saga Musix | Note Added: 0002595 | |
2016-08-12 19:41 | manx | Note Added: 0002596 | |
2017-02-12 14:46 | Saga Musix | Assigned To | => Saga Musix |
2017-02-12 14:46 | Saga Musix | Status | new => closed |
2017-02-12 14:46 | Saga Musix | Resolution | open => no change required |
2017-02-12 14:46 | Saga Musix | Target Version | OpenMPT 1.?? (long term goals) => |
2017-02-12 14:46 | Saga Musix | Note Added: 0002876 |