View Issue Details

IDProjectCategoryView StatusLast Update
0000833OpenMPTFeature Requestpublic2016-07-28 13:24
ReporterRapture Assigned To 
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionno change required 
Platformx64OSWindowsOS Version7
Product VersionOpenMPT 1.26.03.* (old testing) 
Summary0000833: Channel Numbering 0-63 instead of 1-64
Description

Would it be possible to add a tiny "hidden feature" to make the channel numbering from channel 0 (as first channel) to channel 63 (as channel 64), like BASS counts it? This would be very useful for certain circumstances. Thanks for getting back to me!

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2016-07-25 16:45

administrator   ~0002519

I don't think it makes sense to do this on the OpenMPT side, because this means that every musician using the tool we're talking about here would have to enable this setting. It's not just OpenMPT but almost all trackers start counting channels at 1, so if another musician wanting to use this tool would like to use e.g. Schism Tracker instead of OpenMPT, the same feature would have to be implemented in Schism. or Milky. Or....

It would make more sense to let the user of the tool specify channels in the range 1-64 rather than 0-63 and the tool internally then should just subtract 1 when passing these channel indices to BASS.

Rapture

Rapture

2016-07-25 17:29

reporter   ~0002520

I know. Therefore I asked this feature to be hidden, and not 0-63 by standard. i.e. 1-64 for everyone as standard (seen by anyone who starts OpenMPT normally, and 0-63 for special occurences (hidden feature) that I need (please see my email if you haven't already, can't talk about it here, why I need it).

Yes, the second solution I/we already had too. But could lead to bugs on the tool-developers side. We'll see.

Saga Musix

Saga Musix

2016-07-25 17:58

administrator   ~0002521

But could lead to bugs on the tool-developers side. We'll see

The other solution would lead to bugs in OpenMPT and any other tracker where this needs feature to be implemented.
OpenMPT prints the channel number in many different GUI elements - off the top of my head: pattern editor channel headers, general tab channel headers, pattern editor status bar, Go To dialog - and I am 100% sure I am missing some GUI elements here, meaning that the feature would be half-broken if I implement it now. It is much easier for Marco in his tool since he can easily review any call to all BASS_* functions and check that the correct number is passed to BASS. Implementing the same in OpenMPT is much more error-prone because we cannot easily find out in advance in which code locations the channel number will be printed.

Rapture

Rapture

2016-07-25 22:34

reporter   ~0002522

Ok, I'll ask Marco if he can do it in the tool, instead of this feature being implemented in OpenMPT.

Saga Musix

Saga Musix

2016-07-28 13:24

administrator   ~0002528

As per Marco, this issue is resolved on his site.

Issue History

Date Modified Username Field Change
2016-07-23 22:46 Rapture New Issue
2016-07-25 16:45 Saga Musix Note Added: 0002519
2016-07-25 17:29 Rapture Note Added: 0002520
2016-07-25 17:58 Saga Musix Note Added: 0002521
2016-07-25 22:34 Rapture Note Added: 0002522
2016-07-28 13:24 Saga Musix Status new => closed
2016-07-28 13:24 Saga Musix Resolution open => no change required
2016-07-28 13:24 Saga Musix Note Added: 0002528