View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000687 | OpenMPT | Feature Request | public | 2015-06-26 23:30 | 2021-09-15 13:29 |
Reporter | Beyond | Assigned To | |||
Priority | low | Severity | trivial | Reproducibility | N/A |
Status | new | Resolution | open | ||
Summary | 0000687: Show 8 channels in 'General' (instead of 4) | ||||
Description | Sometimes I get a little annoyed when working with the channels in the 'General' tab. I think things could get easier if eight channels at a time were displayed there instead of four. | ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | |||||
Tested code revision (in case you know it) | |||||
has duplicate | 0001089 | closed | Number of channels displayed on General tab to match available screen real estate | |
child of | 0000701 | assigned | Saga Musix | Move plugin settings to separate tab, add modular view |
Or 12 channels, or 16, or ... |
|
If he's having the same problem as I did, it may be the navigating between tabs that he's annoyed with. I refer everyone to this FR: |
|
I will consider this feature request once the plugin settings are on their own tab, since then we won't have to care about scrolling one thing but not the other anymore. |
|
why not just have how many channels u want in the general tab just be an option in the settings so u can have as many channels as u want??? |
|
Because, once again, this would require the entire code to be rewritten anyway. The current "code" is just four copypasted resources - having a variable amount would mean converting the resources to dynamically generated elements. Plus, I'd like to get rid of the tabs and use a scroll bar instead, but that won't work nicely as long as the plugin box is below that, because it would just scroll along. As said, I'll tackle that once the plugin box is somewhere else (which will hopefully be the case in OpenMPT 1.26) |
|
I've been working on this a while ago, and while it works in general - it's slow. It's not my code that's slow, it's just that creating WinAPI controls is slow in general, especially if an application allows the system to style the controls for XP/Vista/7/8/10 looks (like OpenMPT does). It takes about 1-2ms to instantiate a control, which may not seem much at first. But there are 15 controls per channel, so switching to the General Tab of a module with the maximum amount of channels (127) would take 3-5 seconds every time. Clearly this approach won't work. Maybe we can reduce the number of controls to only create as many as there fit on the screen (but this has negative implications for blind users relying on screen readers), or avoid recreating the controls everytime you switch away from the General Tab. |
|
Plus, I'd like to get rid of the tabs and use a scroll bar instead" Excactly my thought when I saw this topic. This wouldn't be solved with just adding 8 channels to the general-view, but what Saga said here would. So why not just do that, remove the tabs completely and make a scrollable mixer-view with all the channels laid out - that also makes layout-symmetry sense to the pattern-view as well. I'm guessing this is exactly what you're going for Saga? Excited for the farthen day this change will happen :D |
|
That's what the patch above does, but as said - initializing the General Tab is awfully slow once you have a few dozen channels. It's not really practicable in its current state. Maybe lazy loading will do the trick... |
|
On top of the slowness, a module with 127 channels consumes about 900 GDI handles with this strategy. This really doesn't scale well with the default limit of GDI handles per process being 10000 (could maybe load 10-11 modules with so many channels before OpenMPT essentially becomes unusable). |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2015-06-26 23:30 | Beyond | New Issue | |
2015-06-26 23:35 | Saga Musix | Note Added: 0002076 | |
2015-06-26 23:36 | Saga Musix | View Status | private => public |
2015-06-29 22:49 | harbinger | Note Added: 0002096 | |
2015-08-16 23:38 | Saga Musix | Relationship added | child of 0000701 |
2015-08-16 23:39 | Saga Musix | Note Added: 0002128 | |
2015-09-03 09:18 | goluigi | Note Added: 0002130 | |
2015-09-03 11:47 | Saga Musix | Note Added: 0002131 | |
2015-09-03 16:06 | Saga Musix | Note Edited: 0002131 | |
2018-02-18 17:35 | Saga Musix | Relationship added | has duplicate 0001089 |
2021-05-13 15:23 | Saga Musix | Note Added: 0004766 | |
2021-05-13 15:26 | Saga Musix | Note Edited: 0004766 | |
2021-05-13 17:33 | Saga Musix | Note Added: 0004767 | |
2021-05-13 17:33 | Saga Musix | File Added: MultiChannelEdit.patch.7z | |
2021-05-16 20:16 | ASIKWUSpulse | Note Added: 0004770 | |
2021-05-16 20:19 | Saga Musix | Note Added: 0004771 | |
2021-09-15 13:29 | Saga Musix | Note Added: 0004872 |