View Issue Details

IDProjectCategoryView StatusLast Update
0000681OpenMPTGeneralpublic2015-04-21 22:10
Reporterquartertoner Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version7
Product VersionOpenMPT 1.24.04.00 / libopenmpt 0.2-beta12 (upgrade first) 
Target VersionOpenMPT 1.25.01.00 / libopenmpt 0.2-beta13 (upgrade first)Fixed in VersionOpenMPT 1.25.01.00 / libopenmpt 0.2-beta13 (upgrade first) 
Summary0000681: Changing octave of a note broken for non-12TET tunings
Description

When one changes the tuning of an instrument to something other than 12TET, there is an inability to quickly change the octave of the note using pre-existing keyboard shortcuts such as the numbers 1-9, and the ctl-shift-q and ctrl-shift-a

Steps To Reproduce

Make a new .mptm, then make an instrument. Duplicate the 12TET tuning as a tune-specific tuning, then change the group size to any number other than 12. The bug is seen with 6, 16, 24, and presumably all other numbers.
Make a note in the pattern section, then try using 0-9 and ctrl-shift-q or ctrl-shift-a.
Instead of changing the pitch by an octave, it will change the note by 12 notes. The shortcuts assume a 12TET tuning is used.

Additional Information

I'm sorry if the bug report wasn't good enough, it's my first for any project, and I'm still new to OpenMPT itself.

TagsNo tags attached.
Has the bug occurred in previous versions?Yes, 1.24.03.00
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2015-04-21 13:32

administrator   ~0002041

Well technically the expected thing is happening, since all menu entries and shortcuts are named "+/- 12", not "octave +/-1". I'll see what can be done about applying instrument settings to the transpose and find&replace octave options though, but might be somewhat tricky to implement. Note that there is already a "transpose custom" option which you can use to transpose any amount, it's just one more key press for the time being.

quartertoner

quartertoner

2015-04-21 20:10

reporter   ~0002043

Ahh, okay! You're right. Thank you for pointing that out to me.

Saga Musix

Saga Musix

2015-04-21 20:11

administrator   ~0002044

Okay, the transposition and data entry shortcuts now take instrument tuning group sizes into account. Same applies to transposition in the instrument's note map.
You can grab an updated built to try at http://buildbot.openmpt.org/builds/

<blockquote>I'm sorry if the bug report wasn't good enough, it's my first for any project, and I'm still new to OpenMPT itself.</blockquote>
It was formulated very well in comparison to some reports we get from recurring users, so kudos :)

quartertoner

quartertoner

2015-04-21 22:08

reporter   ~0002045

Awesome: I downloaded it and it worked exactly as it should!
Thank you!

Issue History

Date Modified Username Field Change
2015-04-20 22:30 quartertoner New Issue
2015-04-20 22:32 quartertoner Additional Information Updated
2015-04-21 05:45 Saga Musix Assigned To => Saga Musix
2015-04-21 05:45 Saga Musix Status new => assigned
2015-04-21 13:32 Saga Musix Note Added: 0002041
2015-04-21 20:10 quartertoner Note Added: 0002043
2015-04-21 20:11 Saga Musix Note Added: 0002044
2015-04-21 20:11 Saga Musix Status assigned => feedback
2015-04-21 20:11 Saga Musix Target Version => OpenMPT 1.25.01.00 / libopenmpt 0.2-beta13 (upgrade first)
2015-04-21 22:08 quartertoner Note Added: 0002045
2015-04-21 22:08 quartertoner Status feedback => assigned
2015-04-21 22:10 Saga Musix Status assigned => resolved
2015-04-21 22:10 Saga Musix Resolution open => fixed
2015-04-21 22:10 Saga Musix Fixed in Version => OpenMPT 1.25.01.00 / libopenmpt 0.2-beta13 (upgrade first)