View Issue Details

IDProjectCategoryView StatusLast Update
0000608OpenMPTFeature Requestpublic2014-11-29 00:11
ReporterLDAsh Assigned ToSaga Musix  
Status resolvedResolutionfixed 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT / libopenmpt 0.2-beta6 (upgrade first) 
Target VersionOpenMPT / libopenmpt 0.2-beta8 (upgrade first)Fixed in VersionOpenMPT / libopenmpt 0.2-beta8 (upgrade first) 
Summary0000608: Dump/replace/open ALL sample based on filename

The ability to save out and load in ALL samples in a file based on their filename, like a "replace-all samples" feature. As works get bigger and bigger, and having varying sample qualities to constantly replace (working on different systems of varying performance and audio hardware capabilities) the tedious task of needing to replace each sample from say 8bit@22KHz to 16bit@44KHz becomes more and more bothersome. A "replace-all samples" feature, perhaps using some filename* mechanism, would be very useful.

Steps To Reproduce

Open a file in the 'sample' tab to replace your sample with simply a different quality sample, and repeat a few hundred times until you wish for some way to automate the process based on filename.

TagsNo tags attached.
Has the bug occurred in previous versions?Yes
Tested code revision (in case you know it)


Saga Musix

Saga Musix

2014-11-16 17:19

administrator   ~0001842

Last edited: 2014-11-16 17:20

May I suggest the following workflow to you:
1) Rearrange samples through the Cleanup dialog, to get rid of any empty sample slots (
2) Shift+Click the Save button in the sample editor dialog to dump all samples. Move the "%sample_number%" to the beginning of the filename so that samples can sorted easily.
3) Edit your samples in an external application
4) Remove all samples, again through the Cleanup dialog
5) Load all samples into the sample editor again. They should be sorted automatically by the Operating System if you made use of the %sample_number% as described in step 2.

That should pretty much do what you want?

PS: Your samples don't magically become better by upsampling them. It's still the same old sample with missing high frequency content.



2014-11-16 17:28

reporter   ~0001843

Last edited: 2014-11-16 17:29

Thanks a million, I will give that a try! Hopefully it works but I am ending up with 100s by now, with each octave of each instrument having its own sample, with many dozens of instruments. I'm hoping your advice won't break how they are organised in the instruments or muddle the filenames too much.

As for the quality, they are originally much higher than 16bit@44KHz and actually get saved at a lower quality for lower-end systems, right down to being able to compose on a handheld. :P

Saga Musix

Saga Musix

2014-11-16 18:08

administrator   ~0001844

Okay, I think step might be problematic, since it will also remove any references to these samples in the patterns/instruments... however, since the current OpenMPT builds already have some new on-disk sample functionality, I can probably extend this functionality to allow reloading all samples at once.

Saga Musix

Saga Musix

2014-11-20 19:34

administrator   ~0001851

Please have a look at the latest test versions (r4606 or newer from The scenario I described earlier show now work with a few steps changed slightly:
1) Shift+Click the Save button in the sample editor dialog to dump all samples.
2) Edit your samples in an external application
3) In the tree view, right-click a sample and choose "Reload All".



2014-11-23 09:55

reporter   ~0001853

Sorry for the delay, I've been sick over the last few days...

Maybe I'm blind but I can't find any "Reload All" button. I can dump all the samples just fine with good (although limited to 26 character?) filenames, but I can't bring them back in in an easy way. If there's a sample already there, I can see a 'Reload' item, but no 'Reload All'.

...On a side note, for some reason the main file buttons in the 'Samples tab' (top-left) are hidden under their own GUI, I can see half the 'save' button but the others to the right are hidden:-

Saga Musix

Saga Musix

2014-11-23 20:48

administrator   ~0001854

The file name length itself shouldn't be limited, but yes, sample names are limited to 25 or something characters in IT/MPTM.
Did you maybe right-click on a sample that doesn't have a sample path set? That's the only possible explanation that I can see right now for "Reload All" not showing up.

Regarding that screenshot, it looks to me like your custom Windows theme messes up with icons sizes and makes them larger than OpenMPT gives them space. Surely OpenMPT won't be the only application where things are larger than normal because of this theme?



2014-11-28 09:01

reporter   ~0001855

Okay, forget the theme issue, you are right. :P

I got it to work by following your instruction of setting the path. I only needed to set the path for 1 sample and then I can see "Reload All" menu item suddenly and it works for all samples. I didn't even need to do a cleanup.

I've only done a very quick test so far because I need to organise all of my samples, but as best I can tell - this is working! :D Very happy and thank you!

Saga Musix

Saga Musix

2014-11-28 09:55

administrator   ~0001856

Oh yes, you're right - Reload All only shows up when Reload would be shown as well, i.e. if the selected sample is a linked sample. This is probably not the smartest thing to do...

Saga Musix

Saga Musix

2014-11-29 00:11

administrator   ~0001857

Reload All should now always be shown if at least one sample has a path set. I'll consider this fixed/implemented then. :)

Issue History

Date Modified Username Field Change
2014-11-16 17:15 LDAsh New Issue
2014-11-16 17:19 Saga Musix Note Added: 0001842
2014-11-16 17:19 Saga Musix Assigned To => Saga Musix
2014-11-16 17:19 Saga Musix Status new => feedback
2014-11-16 17:20 Saga Musix Note Edited: 0001842
2014-11-16 17:20 Saga Musix Assigned To Saga Musix =>
2014-11-16 17:28 LDAsh Note Added: 0001843
2014-11-16 17:28 LDAsh Status feedback => new
2014-11-16 17:29 LDAsh Note Edited: 0001843
2014-11-16 18:08 Saga Musix Note Added: 0001844
2014-11-19 21:36 Saga Musix Assigned To => Saga Musix
2014-11-19 21:36 Saga Musix Status new => assigned
2014-11-20 19:34 Saga Musix Note Added: 0001851
2014-11-20 19:34 Saga Musix Status assigned => feedback
2014-11-23 09:55 LDAsh Note Added: 0001853
2014-11-23 09:55 LDAsh Status feedback => assigned
2014-11-23 20:48 Saga Musix Note Added: 0001854
2014-11-28 09:01 LDAsh Note Added: 0001855
2014-11-28 09:55 Saga Musix Note Added: 0001856
2014-11-29 00:11 Saga Musix Note Added: 0001857
2014-11-29 00:11 Saga Musix Status assigned => resolved
2014-11-29 00:11 Saga Musix Resolution open => fixed
2014-11-29 00:11 Saga Musix Fixed in Version => OpenMPT / libopenmpt 0.2-beta8 (upgrade first)
2014-11-29 00:11 Saga Musix Target Version => OpenMPT / libopenmpt 0.2-beta8 (upgrade first)