View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000590OpenMPTGeneralpublic2014-09-20 15:152014-10-05 14:25
Reporterncovert Assigned ToSaga Musix  
PrioritynormalSeveritymajorReproducibilityrandom
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version7
Product VersionOpenMPT 1.23.05.00 / libopenmpt 0.2-beta6 (upgrade first) 
Target VersionOpenMPT 1.24.01.00 / libopenmpt 0.2-beta8 (upgrade first)Fixed in VersionOpenMPT 1.24.01.00 / libopenmpt 0.2-beta8 (upgrade first) 
Summary0000590: Modified loops in MOD files
Description

Sometimes, after saving a sample with a loop ending exactly at the sample end, I go back to working on that module, and there are a couple additional samples at the end past the loop, and the loop is screwed up, for example it may have audible clicks that used to not be present, or it could be higher pitched in the case of chiptune samples.

Steps To Reproduce

Create a MOD with MPT.
Load a sample in any slot and set a loop start and end point.
Trim off the end of the sample so the loop endpoint is the last sample.
Save the file and restart MPT.
Load the module again. Then see if the loop sounds different.

TagsNo tags attached.
Attached Files
Space Vibe.zip (297 bytes)
Has the bug occurred in previous versions?No.
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2014-09-20 15:30

administrator   ~0001794

Last edited: 2014-09-20 15:31

Loop points in MOD files have to be divisible by 2, due to how the format works. Perhaps it's this difference? If the difference is more than one, can you give an example sample which can be used to reproduce the problem?
(You will have to zip your example module, otherwise the bugtracker will reject the file, I guess)
ncovert

ncovert

2014-09-20 15:36

reporter   ~0001795

Use the Space Vibe sample. Set the loop start to 447 and the loop end to 466. Save the MOD and restart MPT. The loop will have changed to be higher pitched, and there will also be an extra two samples after the loop.
Saga Musix

Saga Musix

2014-09-20 15:56

administrator   ~0001796

The loop length change cannot be "fixed" because MOD can only have loops of even length as said. However, it should be easy enough to fix the two missing sample points in the loop, that looks like a simple rounding bug.
Saga Musix

Saga Musix

2014-09-22 23:30

administrator   ~0001799

Fixed in r4098 (up at http://buildbot.openmpt.org/builds/auto/openmpt-win32/ in a few minutes)

Issue History

Date Modified Username Field Change
2014-09-20 15:15 ncovert New Issue
2014-09-20 15:30 Saga Musix Note Added: 0001794
2014-09-20 15:31 Saga Musix Note Edited: 0001794
2014-09-20 15:36 ncovert Note Added: 0001795
2014-09-20 15:36 ncovert File Added: Space Vibe.zip
2014-09-20 15:56 Saga Musix Assigned To => Saga Musix
2014-09-20 15:56 Saga Musix Status new => assigned
2014-09-20 15:56 Saga Musix Note Added: 0001796
2014-09-22 23:30 Saga Musix Note Added: 0001799
2014-09-22 23:30 Saga Musix Status assigned => feedback
2014-10-05 14:25 Saga Musix Status feedback => resolved
2014-10-05 14:25 Saga Musix Resolution open => fixed
2014-10-05 14:25 Saga Musix Fixed in Version => OpenMPT 1.24.01.00 / libopenmpt 0.2-beta8 (upgrade first)
2014-10-05 14:25 Saga Musix Target Version => OpenMPT 1.24.01.00 / libopenmpt 0.2-beta8 (upgrade first)