View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000584OpenMPTUser Interfacepublic2014-08-30 22:102014-09-02 13:13
Reporterjmkz Assigned ToSaga Musix  
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version8
Product VersionOpenMPT 1.23.04.* (old testing) 
Target VersionOpenMPT 1.23.05.00 / libopenmpt 0.2-beta6 (upgrade first)Fixed in VersionOpenMPT 1.23.05.00 / libopenmpt 0.2-beta6 (upgrade first) 
Summary0000584: Undo and redo functions broken in sample editor (OpenMPT 32-bits)
Description

Undo and redo functions are broken, throws a crash.

Undo: https://dl.dropboxusercontent.com/u/35217013/mptrack/bugtracker/584/crash-undo.dmp

Redo: https://dl.dropboxusercontent.com/u/35217013/mptrack/bugtracker/584/redo-mptrack.DMP.7z

Steps To Reproduce

Into a new module load a sample and modify, e.g. resample, silence. If you undo action throws a crash dialog.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)4220

Activities

Saga Musix

Saga Musix

2014-08-30 22:12

administrator   ~0001775

Last edited: 2014-08-30 22:14

Unable to confirm. In case you are using a custom build, please do a full recompile. If that doesn't help, please report back so that I can provide a build for which I actually have debug symbols so that the memory dumps are actually useful.
jmkz

jmkz

2014-08-30 23:24

reporter   ~0001776

I was sure of buildbot win32 4220, but here it's again:

https://dl.dropboxusercontent.com/u/35217013/mptrack/bugtracker/584/2014-08-30%2016.19.09.7z
Saga Musix

Saga Musix

2014-08-30 23:33

administrator   ~0001777

As said, memory dumps of builds that I don't have debug symbols of are of no use, so please use this one for generating a memory dump instead: http://sagagames.de/stuff/mptrack.exe - Also, please verify your sample undo buffer size (Setup -> Samples)
FWIW, I am unable to get the sample editor to crash in the buildbot builds as well.
jmkz

jmkz

2014-08-30 23:53

reporter   ~0001778

I was not aware of the undo buffer, it was 0%. I used to have it at 30% but don't know when is set to zero. It does crash when buffer at 0 percent, both w32/w64.

https://dl.dropboxusercontent.com/u/35217013/mptrack/bugtracker/584/vs10_mptrack.7z
Saga Musix

Saga Musix

2014-08-31 16:03

administrator   ~0001779

r4222 should fix crashes when sample undo is disabled completely or a sample larger than the configured undo buffer size is being edited.
jmkz

jmkz

2014-09-02 02:13

reporter   ~0001783

It's fixed now, Thanks!

Issue History

Date Modified Username Field Change
2014-08-30 22:10 jmkz New Issue
2014-08-30 22:12 jmkz Description Updated
2014-08-30 22:12 Saga Musix Note Added: 0001775
2014-08-30 22:14 Saga Musix Note Edited: 0001775
2014-08-30 23:24 jmkz Note Added: 0001776
2014-08-30 23:33 Saga Musix Note Added: 0001777
2014-08-30 23:53 jmkz Note Added: 0001778
2014-08-30 23:56 Saga Musix Assigned To => Saga Musix
2014-08-30 23:56 Saga Musix Status new => assigned
2014-08-31 16:03 Saga Musix Note Added: 0001779
2014-08-31 16:03 Saga Musix Status assigned => feedback
2014-08-31 16:03 Saga Musix Target Version => OpenMPT 1.23.05.00 / libopenmpt 0.2-beta6 (upgrade first)
2014-09-02 02:13 jmkz Note Added: 0001783
2014-09-02 02:13 jmkz Status feedback => assigned
2014-09-02 13:13 Saga Musix Has the bug occurred in previous versions? Not in current stable =>
2014-09-02 13:13 Saga Musix Status assigned => resolved
2014-09-02 13:13 Saga Musix Resolution open => fixed
2014-09-02 13:13 Saga Musix Fixed in Version => OpenMPT 1.23.05.00 / libopenmpt 0.2-beta6 (upgrade first)