View Issue Details

IDProjectCategoryView StatusLast Update
0000486OpenMPTGeneralpublic2014-02-17 16:33
Reporterivo Assigned Tomanx  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSWindowsOS VersionVista
Product VersionOpenMPT 1.22.07.* (old testing) 
Target VersionOpenMPT 1.23.01.00 (upgrade first)Fixed in VersionOpenMPT 1.23.01.00 (upgrade first) 
Summary0000486: OMPT crash
Description

OpenMPT 1.22.07.21-r3717 TEST
Build Date: 2014-02-15 14:54:16

OMPT always crashes opening one module. not the others modules.

TagsNo tags attached.
Attached Files
crash.7z (8,884 bytes)
2014-02-17 13.26.08.7z (8,848 bytes)
Has the bug occurred in previous versions?yes
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2014-02-15 16:35

administrator   ~0001529

Please provide the module that crashes OpenMPT.

ivo

ivo

2014-02-15 16:49

reporter   ~0001530

it will be difficult.
it's a 300 mo module and i have a 63 kbs connection ....
(but bigger modules don't crash)

Saga Musix

Saga Musix

2014-02-15 17:45

administrator   ~0001531

Seems like I won't be able to use a crash dump from that version as I don't have the debugging files from the buildbot builds, so please download the build from http://sagagames.de/stuff/mptrack.exe - reproduce the crash with that one and upload the generated memory dump.

Saga Musix

Saga Musix

2014-02-17 00:47

administrator   ~0001537

Last edited: 2014-02-17 00:48

Please add a comment the next time you add a crash dump, I didn't see the uploaded file, so once again I don't have the debug information for this test build anymore. A new build is already available under the same address, for which I have debug information.

ivo

ivo

2014-02-17 07:52

reporter   ~0001538

oops sorry.
anyway it also crashes with xp.
I think there was a problem during my backup.
I remade another same module and I have no problem.
thank you jojo.

Saga Musix

Saga Musix

2014-02-17 09:31

administrator   ~0001539

So the bug is gone or what?

ivo

ivo

2014-02-17 10:16

reporter   ~0001540

only one module crashed in vista and xp, not the other ones.
so i think it was an exceptional backup problem only with this module.
I remade exactly the same module and i have no more problem with.

Saga Musix

Saga Musix

2014-02-17 12:17

administrator   ~0001541

Well, of course it's possible that some bad disk sectors or whatever have caused the crash, but the disassembly from the crash dump doesn't look like that (though we had an issue like that before). So if you still have the file which caused the problem, please recreate the problem using the latest test version, just to go sure. We don't want OpenMPT to crash on valid or corrupt files.

ivo

ivo

2014-02-17 12:32

reporter   ~0001542

so.
with the just now downloaded:
OpenMPT 1.22.07.22-r3726!+ TEST
Build Date: 2014-02-17 01:37:57
and exactly the same crashed backuped module.

2014-02-17 13.26.08.7z uploaded

Saga Musix

Saga Musix

2014-02-17 12:37

administrator   ~0001543

Thanks, I see what's most likely going on there now; I'd guess that the file got truncated when saving / copying, so when loading some sample, it's reading past the file end. Should be able to fix that easily.

Saga Musix

Saga Musix

2014-02-17 12:55

administrator   ~0001544

manx, this was introduced in your refactoring commit 2438, the security checks in CopyStereoSplitSample were removed. Previously, if there was not enough incoming data, the method read as much of the left and right channel as possible, but now it simply crashes if there's not enough incoming data for the right channel. Can you fix this?

manx

manx

2014-02-17 14:37

administrator   ~0001545

This should be fixed in r3727 now, could you please check if http://manx.datengang.de/openmpt/temp/mptrack-3727.7z works without crashing now?
Keep in mind though that the module that crashed before is most likely corrupted somehow and has missing sample data for at least one of its samples.

ivo

ivo

2014-02-17 16:27

reporter   ~0001546

fixed with r3727.
no problem to open the module.
one truncated sample.
some missing samples.
thanks manx.

Issue History

Date Modified Username Field Change
2014-02-15 16:33 ivo New Issue
2014-02-15 16:35 Saga Musix Note Added: 0001529
2014-02-15 16:49 ivo Note Added: 0001530
2014-02-15 17:45 Saga Musix Note Added: 0001531
2014-02-15 18:01 ivo File Added: crash.7z
2014-02-17 00:47 Saga Musix Note Added: 0001537
2014-02-17 00:48 Saga Musix Note Edited: 0001537
2014-02-17 07:52 ivo Note Added: 0001538
2014-02-17 09:31 Saga Musix Note Added: 0001539
2014-02-17 10:16 ivo Note Added: 0001540
2014-02-17 12:17 Saga Musix Note Added: 0001541
2014-02-17 12:31 ivo File Added: 2014-02-17 13.26.08.7z
2014-02-17 12:32 ivo Note Added: 0001542
2014-02-17 12:37 Saga Musix Note Added: 0001543
2014-02-17 12:54 Saga Musix Assigned To => manx
2014-02-17 12:54 Saga Musix Status new => assigned
2014-02-17 12:55 Saga Musix Note Added: 0001544
2014-02-17 14:37 manx Note Added: 0001545
2014-02-17 14:37 manx Status assigned => feedback
2014-02-17 16:27 ivo Note Added: 0001546
2014-02-17 16:27 ivo Status feedback => assigned
2014-02-17 16:28 manx Status assigned => resolved
2014-02-17 16:28 manx Fixed in Version => OpenMPT 1.23.01.00 (upgrade first)
2014-02-17 16:28 manx Resolution open => fixed
2014-02-17 16:33 Saga Musix Target Version => OpenMPT 1.23.01.00 (upgrade first)