View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000486 | OpenMPT | General | public | 2014-02-15 16:33 | 2014-02-17 16:33 |
Reporter | ivo | Assigned To | manx | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | x86 | OS | Windows | OS Version | Vista |
Product Version | OpenMPT 1.22.07.* (old testing) | ||||
Target Version | OpenMPT 1.23.01.00 (upgrade first) | Fixed in Version | OpenMPT 1.23.01.00 (upgrade first) | ||
Summary | 0000486: OMPT crash | ||||
Description | OpenMPT 1.22.07.21-r3717 TEST OMPT always crashes opening one module. not the others modules. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Has the bug occurred in previous versions? | yes | ||||
Tested code revision (in case you know it) | |||||
Please provide the module that crashes OpenMPT. |
|
it will be difficult. |
|
Seems like I won't be able to use a crash dump from that version as I don't have the debugging files from the buildbot builds, so please download the build from http://sagagames.de/stuff/mptrack.exe - reproduce the crash with that one and upload the generated memory dump. |
|
Please add a comment the next time you add a crash dump, I didn't see the uploaded file, so once again I don't have the debug information for this test build anymore. A new build is already available under the same address, for which I have debug information. |
|
oops sorry. |
|
So the bug is gone or what? |
|
only one module crashed in vista and xp, not the other ones. |
|
Well, of course it's possible that some bad disk sectors or whatever have caused the crash, but the disassembly from the crash dump doesn't look like that (though we had an issue like that before). So if you still have the file which caused the problem, please recreate the problem using the latest test version, just to go sure. We don't want OpenMPT to crash on valid or corrupt files. |
|
so. 2014-02-17 13.26.08.7z uploaded |
|
Thanks, I see what's most likely going on there now; I'd guess that the file got truncated when saving / copying, so when loading some sample, it's reading past the file end. Should be able to fix that easily. |
|
manx, this was introduced in your refactoring commit 2438, the security checks in CopyStereoSplitSample were removed. Previously, if there was not enough incoming data, the method read as much of the left and right channel as possible, but now it simply crashes if there's not enough incoming data for the right channel. Can you fix this? |
|
This should be fixed in r3727 now, could you please check if http://manx.datengang.de/openmpt/temp/mptrack-3727.7z works without crashing now? |
|
fixed with r3727. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2014-02-15 16:33 | ivo | New Issue | |
2014-02-15 16:35 | Saga Musix | Note Added: 0001529 | |
2014-02-15 16:49 | ivo | Note Added: 0001530 | |
2014-02-15 17:45 | Saga Musix | Note Added: 0001531 | |
2014-02-15 18:01 | ivo | File Added: crash.7z | |
2014-02-17 00:47 | Saga Musix | Note Added: 0001537 | |
2014-02-17 00:48 | Saga Musix | Note Edited: 0001537 | |
2014-02-17 07:52 | ivo | Note Added: 0001538 | |
2014-02-17 09:31 | Saga Musix | Note Added: 0001539 | |
2014-02-17 10:16 | ivo | Note Added: 0001540 | |
2014-02-17 12:17 | Saga Musix | Note Added: 0001541 | |
2014-02-17 12:31 | ivo | File Added: 2014-02-17 13.26.08.7z | |
2014-02-17 12:32 | ivo | Note Added: 0001542 | |
2014-02-17 12:37 | Saga Musix | Note Added: 0001543 | |
2014-02-17 12:54 | Saga Musix | Assigned To | => manx |
2014-02-17 12:54 | Saga Musix | Status | new => assigned |
2014-02-17 12:55 | Saga Musix | Note Added: 0001544 | |
2014-02-17 14:37 | manx | Note Added: 0001545 | |
2014-02-17 14:37 | manx | Status | assigned => feedback |
2014-02-17 16:27 | ivo | Note Added: 0001546 | |
2014-02-17 16:27 | ivo | Status | feedback => assigned |
2014-02-17 16:28 | manx | Status | assigned => resolved |
2014-02-17 16:28 | manx | Fixed in Version | => OpenMPT 1.23.01.00 (upgrade first) |
2014-02-17 16:28 | manx | Resolution | open => fixed |
2014-02-17 16:33 | Saga Musix | Target Version | => OpenMPT 1.23.01.00 (upgrade first) |