View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000376 | OpenMPT | File Format Support | public | 2013-04-15 02:51 | 2013-04-18 15:12 |
Reporter | moltres_rider | Assigned To | Saga Musix | ||
Priority | normal | Severity | block | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | x64 | OS | Windows | OS Version | 7 |
Product Version | OpenMPT 1.22.01.00 (upgrade first) | ||||
Summary | 0000376: Some DLS banks broken again | ||||
Description | some DLS banks are broken in the new version. when previewing the bank, they preview just find but are a bad distorted sound when added to ANY module | ||||
Steps To Reproduce | load any drum kit DLS bank | ||||
Additional Information | one example of a broken DLS bank in ModPlug http://www.mediafire.com/download.php?2m2xdli5av20v2k | ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | |||||
Tested code revision (in case you know it) | |||||
The bank you provided plays just fine here. Are you sure it's the correct file? There is no reason why it should play fine in the preview and then break when adding it to a module, because the same code is used for both actions. If it "distorts", maybe the sample pre-amp of the module you add it to is simply too loud? |
|
right file... not only is it distorted, it is a 40 second sound sample when the DLS bank is only a couple of seconds... XM format... |
|
Thanks for being terribly unspecific in the original report. The sample is imported at a wrong pitch in the XM format, but it's not distorted or anything. when added to ANY module Never ever use the word "any" again, will you? Obviously it is not a problem with "any" module, but only with XM files. If you only reproduce it with XM files, then say so in the description, and don't say "any files". Besides, this file didn't load in previous versions (before 1.22) at all. |
|
I found out what was wrong... it "distorts" and lengthens if the 'mix level' are set to 'compatible'... so the issue has changed, the issue needs to be fixed with the 'compatible' mix level setting |
|
No, the mix levels have absolutely nothing to do with this. The problem affects XM files only, no matter what their mix levels are being set to. |
|
can you fix the XM file issue then... |
|
It's not really a bug, it's just that this particular drum sample ranges from C-0 to B-10, and since you can't map notes to other notes in the XM format, OpenMPT simply picks the lowest note of the range as a center note. That's simply a limitation of the XM format, but I've modified the code a bit to choose the center of the note range instead of the lowest note, which helps in this particular case but might still screw up in other cases. http://sagagames.de/stuff/mptrack.exe |
|
Thanks for not giving any feedback. I'll just assume it's fixed. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2013-04-15 02:51 | moltres_rider | New Issue | |
2013-04-15 11:24 | Saga Musix | Note Added: 0001172 | |
2013-04-15 12:24 | moltres_rider | Note Added: 0001173 | |
2013-04-15 12:29 | Saga Musix | Note Added: 0001174 | |
2013-04-15 12:29 | moltres_rider | Note Added: 0001175 | |
2013-04-15 12:31 | Saga Musix | Note Added: 0001176 | |
2013-04-15 13:06 | moltres_rider | Note Added: 0001177 | |
2013-04-15 21:03 | Saga Musix | Note Added: 0001178 | |
2013-04-15 21:03 | Saga Musix | Assigned To | => Saga Musix |
2013-04-15 21:03 | Saga Musix | Status | new => feedback |
2013-04-18 15:12 | Saga Musix | Note Added: 0001184 | |
2013-04-18 15:12 | Saga Musix | Status | feedback => resolved |
2013-04-18 15:12 | Saga Musix | Resolution | open => fixed |