View Issue Details

IDProjectCategoryView StatusLast Update
0000311OpenMPTPlayback Compatibilitypublic2012-11-18 13:44
Reportermoltres_rider Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSWindowsOS Version7
Product VersionOpenMPT 1.20.04.00 (upgrade first) 
Target VersionOpenMPT 1.21.01.00 (upgrade first)Fixed in VersionOpenMPT 1.21.01.00 (upgrade first) 
Summary0000311: looping pattern x amount of times using E60 & E63 creates an infinite pattern loop in .mod files
Description

if you have a E60 & an E63 in the same pattern (to loop three times) the pattern loops indefinitely

Steps To Reproduce

open a mod downloaded from the Mod Archive that has E60 & E63 in it... press play, pattern loops indefinitely

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2012-11-17 13:26

administrator   ~0000937

The example file you provided on the forum plays perfectly here in OpenMPT 1.20.04.00, there are no infinite loops. There is nothing wrong with the pattern loop behaviour.

Saga Musix

Saga Musix

2012-11-17 13:58

administrator   ~0000938

Clarification: The problem only happens with this file: http://modarchive.org/module.php?108033 and only if "Loop Song" is off. It happens because of the crazy pattern jumps. OpenMPT would have to keep track of the order of all played rows of the current pattern to fix this behaviour, which I don't currently think is a good idea to do.

moltres_rider

moltres_rider

2012-11-17 14:14

reporter   ~0000940

why is the loop playing indefinitely at my end then???????

Saga Musix

Saga Musix

2012-11-17 14:14

administrator   ~0000941

Read my previous comment.

moltres_rider

moltres_rider

2012-11-17 15:46

reporter   ~0000942

ok.. I now see that is the file I used... why did you say it plays fine if the linked module is the EXACT module???

moltres_rider

moltres_rider

2012-11-17 15:47

reporter   ~0000943

and why did you mark 'unable to produce' if you said that was an issue with that linked module???

Saga Musix

Saga Musix

2012-11-17 15:48

administrator   ~0000944

Last edited: 2012-11-17 15:49

Am I really that hard to understand? The error you describe only occours if "Loop Song" is off. I never use that feature, it took me quite a while to figure out what you were actually trying to describe (thus the first comment was on the song being played with "Loop Song" on).

Saga Musix

Saga Musix

2012-11-17 16:35

administrator   ~0000945

I've made an attempt at fixing this... Revision 1430 should play the module as intended even if "Loop Song" is off. Try here: http://sagagames.de/stuff/mptrack.exe

moltres_rider

moltres_rider

2012-11-17 16:41

reporter   ~0000946

it only loops once then the whole module stops cold!!!

Saga Musix

Saga Musix

2012-11-17 16:42

administrator   ~0000947

Last edited: 2012-11-17 16:46

Yes, because you have "loop song" disabled. It should stop like every other module you play...
If you want the module to loop forever, you have to enable "loop song", in which case the original problem of this bug report never existed anyway.

moltres_rider

moltres_rider

2012-11-17 16:48

reporter   ~0000948

No, I mean it stops RIGHT AFTER the looped portion of the song!!! it DOESN'T continue with the song!!! just that looped portion plays!!! it won't EVEN loop three times as indicated!!! is that hard to understand???

Saga Musix

Saga Musix

2012-11-17 16:54

administrator   ~0000949

Yes, it is that hard to understand, because you are not being very specific. You said "it only loops once", and that could also mean "the song only loops once" and not only "the specific portion of the pattern I think about only loops once", because, as I've said, I think to have fixed the problem, and OpenMPT plays the song completely on my end, no matter if "Loop Song" is on or off. Are you sure that you have used the new mptrack.exe from my comment above? How do you play the module? Do you simply hit the "Play Song" button?

moltres_rider

moltres_rider

2012-11-17 16:55

reporter   ~0000950

I downloaded the mptrack.exe and replaced the original and hit play...

moltres_rider

moltres_rider

2012-11-17 16:59

reporter   ~0000951

so I hit play again it plays through, so I hit 'play from beginning' 10 more times to see if it was working... three of those 10 stopped after the looped portion... this could be a bug under 'random'

Saga Musix

Saga Musix

2012-11-17 17:00

administrator   ~0000952

The problem only appears to happen when using "Play Song" for the first time after the module has been loaded. It never occours with "Play Song From Start" (which is what I am always using).

moltres_rider

moltres_rider

2012-11-17 17:11

reporter   ~0000953

I closed the module each time... I must have hit 'play' a few times... so I try again... it seems to be an issue with pressing 'play' upon opening...

Saga Musix

Saga Musix

2012-11-17 17:32

administrator   ~0000954

Here's another try, which should also work when just using "Play" instead of "Play from Start": http://sagagames.de/stuff/mptrack.exe

moltres_rider

moltres_rider

2012-11-18 02:07

reporter   ~0000960

works...

Issue History

Date Modified Username Field Change
2012-11-17 04:53 moltres_rider New Issue
2012-11-17 13:26 Saga Musix Note Added: 0000937
2012-11-17 13:26 Saga Musix Status new => closed
2012-11-17 13:26 Saga Musix Resolution open => unable to reproduce
2012-11-17 13:58 Saga Musix Note Added: 0000938
2012-11-17 13:59 Saga Musix Assigned To => Saga Musix
2012-11-17 13:59 Saga Musix Status closed => new
2012-11-17 13:59 Saga Musix Assigned To Saga Musix =>
2012-11-17 14:14 moltres_rider Note Added: 0000940
2012-11-17 14:14 Saga Musix Note Added: 0000941
2012-11-17 14:17 Saga Musix Severity major => minor
2012-11-17 15:46 moltres_rider Note Added: 0000942
2012-11-17 15:47 moltres_rider Note Added: 0000943
2012-11-17 15:48 Saga Musix Note Added: 0000944
2012-11-17 15:49 Saga Musix Note Edited: 0000944
2012-11-17 15:50 Saga Musix Assigned To => Saga Musix
2012-11-17 15:50 Saga Musix Status new => assigned
2012-11-17 15:50 Saga Musix Resolution unable to reproduce => open
2012-11-17 15:50 Saga Musix Target Version => OpenMPT 1.21.01.00 (upgrade first)
2012-11-17 16:35 Saga Musix Note Added: 0000945
2012-11-17 16:35 Saga Musix Status assigned => feedback
2012-11-17 16:41 moltres_rider Note Added: 0000946
2012-11-17 16:41 moltres_rider Status feedback => assigned
2012-11-17 16:42 Saga Musix Note Added: 0000947
2012-11-17 16:46 Saga Musix Note Edited: 0000947
2012-11-17 16:48 moltres_rider Note Added: 0000948
2012-11-17 16:54 Saga Musix Note Added: 0000949
2012-11-17 16:55 moltres_rider Note Added: 0000950
2012-11-17 16:59 moltres_rider Note Added: 0000951
2012-11-17 17:00 Saga Musix Note Added: 0000952
2012-11-17 17:11 moltres_rider Note Added: 0000953
2012-11-17 17:32 Saga Musix Note Added: 0000954
2012-11-17 17:32 Saga Musix Status assigned => feedback
2012-11-18 02:07 moltres_rider Note Added: 0000960
2012-11-18 02:07 moltres_rider Status feedback => assigned
2012-11-18 13:44 Saga Musix Priority high => normal
2012-11-18 13:44 Saga Musix Status assigned => resolved
2012-11-18 13:44 Saga Musix Resolution open => fixed
2012-11-18 13:44 Saga Musix Fixed in Version => OpenMPT 1.21.01.00 (upgrade first)