View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000304OpenMPTFeature Requestpublic2012-10-05 10:442014-02-06 18:45
Reporter404notfound Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.20.03.* (old testing) 
Target VersionOpenMPT 1.23.01.00 (upgrade first)Fixed in VersionOpenMPT 1.23.01.00 (upgrade first) 
Summary0000304: Handling loops with resampling
Description

<passing_by> http://modarchive.org/module.php?63213
<passing_by> mishap with loop points of samples 2 and 3 with this particular file
<Saga_Musix> no, it's just the resampler's fault and my me not overwriting the data behind the loop point with the loop start data anymore
<Saga_Musix> i think using no interpolation gets rid of the problem actually
<Saga_Musix> because it wouldn't have to wrap around or read behind the loop end in that case
<passing_by> works fine in a previous version of ompt
<Saga_Musix> because people complained that data behind the loop point would get modified
<Saga_Musix> obviously you can't have both

Requesting option to switch between the old and the new way of handling loops with resampling on.

TagsNo tags attached.
Attached Files
chiptune_3.mod.zip (3,590 bytes)
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2013-04-10 20:59

administrator   ~0001164

There won't be an option for the old behaviour, but I'm rather going to fix this whole loop read-ahead on interpolation thingy properly.
Saga Musix

Saga Musix

2014-02-01 14:45

administrator   ~0001479

New mixer code is in place and loop handling with interpolation should be much better now. http://sagagames.de/stuff/mptrack.exe
Saga Musix

Saga Musix

2014-02-01 16:11

administrator   ~0001480

And in case you downloaded the executable before I posted this comment, be sure to redownload it as the previous version trashed stereo samples loops in some cases.
404notfound

404notfound

2014-02-03 19:58

reporter   ~0001485

Confirming fix for this tune.
404notfound

404notfound

2014-02-06 13:25

reporter   ~0001486

Last edited: 2014-02-06 13:26

I think this bug might still have effect with InvertLoop effect and Interpolation on. attaches file
Saga Musix

Saga Musix

2014-02-06 16:55

administrator   ~0001487

Should be fixed now.

Issue History

Date Modified Username Field Change
2012-10-05 10:44 404notfound New Issue
2013-04-10 20:59 Saga Musix Assigned To => Saga Musix
2013-04-10 20:59 Saga Musix Status new => assigned
2013-04-10 20:59 Saga Musix Note Added: 0001164
2014-01-15 20:47 Saga Musix Target Version => OpenMPT 1.23.01.00 (upgrade first)
2014-02-01 14:45 Saga Musix Note Added: 0001479
2014-02-01 14:45 Saga Musix Status assigned => feedback
2014-02-01 16:11 Saga Musix Note Added: 0001480
2014-02-03 19:58 404notfound Note Added: 0001485
2014-02-03 19:58 404notfound Status feedback => assigned
2014-02-03 19:59 Saga Musix Status assigned => resolved
2014-02-03 19:59 Saga Musix Resolution open => fixed
2014-02-03 19:59 Saga Musix Fixed in Version => OpenMPT 1.23.01.00 (upgrade first)
2014-02-06 13:25 404notfound Note Added: 0001486
2014-02-06 13:25 404notfound Status resolved => feedback
2014-02-06 13:25 404notfound Resolution fixed => reopened
2014-02-06 13:26 404notfound File Added: chiptune_3.mod.zip
2014-02-06 13:26 404notfound Note Edited: 0001486
2014-02-06 16:55 Saga Musix Note Added: 0001487
2014-02-06 18:45 Saga Musix Status feedback => resolved
2014-02-06 18:45 Saga Musix Resolution reopened => fixed