0000242: XM effect works while it shouldn't

ID	Project	Category	View Status	Date Submitted	Last Update

0000242	OpenMPT	File Format Support	public	2012-04-18 19:00	2012-04-21 18:31

Reporter	LPChip	Assigned To	Saga Musix
Priority	low	Severity	tweak	Reproducibility	always
Status	resolved	Resolution	fixed
Platform	x64	OS	Windows	OS Version	7
Product Version	OpenMPT 1.19.04.00 (upgrade first)
Fixed in Version	OpenMPT 1.20.01.00 (upgrade first)

Summary	0000242: XM effect works while it shouldn't
Description	In the XM format, the Axy command does Volume Slide. When you write in AF1, it actually recognizes this as the IT equivilant: DF1, which is a fine volume slide. This effect however does not exists in XM. In XM one would use EAx and EBx instead. So Whenever someone uses DF1 or D1F, modplug should completely ignore the effect, like other trackers to remind people that they'd need another effect.
Steps To Reproduce	Write a pattern with a sample playing at full volume, and give it AF1 volume slide. Volume should stay normal.
Additional Information	MadTracker will ignore AF1 completely, and according to the specs, its an invalid combination. Even the right-click menu in OpenMPT has it right!
Tags	No tags attached.

Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Saga Musix 2012-04-18 20:42 administrator ~0000693 Last edited: 2012-04-18 22:38	When you write in AF1, it actually recognizes this as the IT equivilant: DF1, which is a fine volume slide. Wrong, DF1 is interpreted as D01, while it should be interpreted as DF0 (not ignored as you claim). Of course that's still wrong, but not the same as your described.

Saga Musix 2012-04-21 18:21 administrator ~0000698	Should be fixed in revision 1252. Please try http://sagagames.de/stuff/mptrack.exe

LPChip 2012-04-21 18:31 manager ~0000700	Confirmed. :)

Date Modified	Username	Field	Change
2012-04-18 19:00	LPChip	New Issue
2012-04-18 20:42	Saga Musix	Note Added: 0000693
2012-04-18 20:45	Saga Musix	Assigned To	=> Saga Musix
2012-04-18 20:45	Saga Musix	Status	new => assigned
2012-04-18 22:38	Saga Musix	Note Edited: 0000693
2012-04-21 18:21	Saga Musix	Note Added: 0000698
2012-04-21 18:21	Saga Musix	Status	assigned => resolved
2012-04-21 18:21	Saga Musix	Fixed in Version	=> OpenMPT 1.20.00.* (old testing)
2012-04-21 18:21	Saga Musix	Resolution	open => fixed
2012-04-21 18:22	Saga Musix	Status	resolved => feedback
2012-04-21 18:22	Saga Musix	Resolution	fixed => reopened
2012-04-21 18:31	LPChip	Note Added: 0000700
2012-04-21 18:31	LPChip	Status	feedback => assigned
2012-04-21 18:31	Saga Musix	Status	assigned => resolved
2012-04-21 18:31	Saga Musix	Resolution	reopened => fixed