View Issue Details

IDProjectCategoryView StatusLast Update
0000229OpenMPTGeneralpublic2012-03-08 11:14
Reporterchristofori Assigned ToSaga Musix  
Status resolvedResolutionfixed 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.20.00.* (old testing) 
Target VersionOpenMPT (upgrade first) 
Summary0000229: "Follow Song" off after find/replace instrument

After FIND (and/or) find/replace for an instrument, "follow song" is off.... F11 (toggle follow song) will sometimes have no effect (cannot reliably reproduce the "toggle follow song has no effect" part..!). I always run with "follow song" on, so it was quickly noticeable that there had been behavioral change... this seems to have popped up only in the last few revisions of the testing build.

Steps To Reproduce

Open a module (currently only have tested MPTM type). Do a search for an instrument (NOTE: searching for an instrument that is NOT in use does not cause the bug -- only when it finds an instance of an instrument -- also haven't tried searching for other objects, only instruments...). Play the module (either from beginning, current row, or current pattern)

TagsNo tags attached.
Has the bug occurred in previous versions?Can only verify existance in
Tested code revision (in case you know it)


Saga Musix

Saga Musix

2012-03-07 22:33

administrator   ~0000623

Last edited: 2012-03-07 22:33

"Follow song" has been turned off when starting a search for quite a while now. I think that after finding something in the pattern, you want to examine that finding, and not look at scrolling patterns. Everything else point be pointless. However, I think that "follow song" shouldn't be turned off when using "Replace All", but that's already done. Or do you have any better examples where "follow song" should be left turned on?



2012-03-07 22:41

reporter   ~0000624

I don't do searches whilst playing back a module; so i'd prefer it to leave "follow song" alone, to be honest.

Saga Musix

Saga Musix

2012-03-07 22:43

administrator   ~0000625

That's a good point! The flag should of course be left untouched if no song is actually playing.



2012-03-07 22:44

reporter   ~0000626

Also worth noting; FINDing an instrument will update the patterndata list but not show you the correct order in the orderlist.. this may also be behavior by design but it confused me. When i do a "find" i would like the current/active row to go to what was found. i suppose this has turned into a setting feature request.



2012-03-07 22:50

reporter   ~0000627

Last edited: 2012-03-07 22:54

Or, if we're really wanting to capitalise on OMPT's multitasking abilities (playing back whilst editing something elsewhere in the same module) perhaps some kind of new window would be called for... opens up when a find/replace is called. It could split the patterndata portion of the pattern tab and have a different/offset color scheme. This way one could easilly see exactly where/what was going on during playback on one side, whilst also being able to tweak something on another side. -- though... i don't want to get TOO carried away here. ;) Though it seems if this kind of thing were implemented, it would make "Follow song" obsolete; as the "playback" portion of the window would have the active row centered (scrolling as it played) anyway, while the user would be quite free to move at will in the editing portion; only occasionally seeing the playback bar whiz by as the tracker came to play the pattern said user was working on... lol. OK.. that's enough for now. :)

Saga Musix

Saga Musix

2012-03-07 22:55

administrator   ~0000628

Regarding comment 0000626, that happens because Find/Replace goes through the pattern from the first pattern to the last pattern; not from the first order item to the last order item; i.e. it is currently "agnostic" of where in the order list the finding is. It is well possible that the pattern something was found in isn't in the order list at all! Sure this can be improved, let's see what can be done...

Saga Musix

Saga Musix

2012-03-07 23:22

administrator   ~0000635

This should be fixed in revision 1208.



2012-03-08 04:33

reporter   ~0000638

Last edited: 2012-03-08 04:52

Don't see any update just yet (which is no problem, i realise it might not be completed and/or ready for testing) -- so hope the timing of this comment is good -- on find/replace, the setting for "Show Prev/Next patterns" is temporarilly ignored/disabled, until another pattern is selected from the ordlist (or upon playback progressing to the next pattern in the orderlist -- IF follow song is on). First opportunity i get with the next build i shall make haste to bring feedback to this and the other recent issues. :D As always, you da man j0jo! Thanks.

[edit -- d'OH! found the updated version.. i'll go test what's been reported and post feedback post haste.]

Reg'd comment 627 -- do you think such would make a useful feature? Enough so that i ought make a feature request for it? i know it'd be quite a while till it shows up -- i just dunno if others might find it useful or not (at all). For me, it wouldn't make a bit of difference since i don't simultaneously play and edit tracks.. but i'm an oddball.. so.. :P

What of a feature to either show (or at least list) patterns containing data which aren't present in the ordlist? (again -- not useful to me, but you did bring up the point..). Currently as i understand it -- the only way to see/edit such a pattern would be to (temporarilly, perhaps) add it back into the ordlist. Again, i don't know if these are useful or trivial.



2012-03-08 04:58

reporter   ~0000639

SLICK -- you either noticed the "Show Prev/Next patterns" thing in-code or saw my note and fixed it prior to (or without) comment! The original issue is also fixed and i like the update to select the pattern in the ordlist (if it's there..) in FINDs as well. :)

i typically do not use patterns that don't in some way appear in my ordlists so i haven't tested functionality in that scenario. However, i'm sure with these modifications that the intended behavior would also apply in that case.

Saga Musix

Saga Musix

2012-03-08 11:13

administrator   ~0000643

<blockquote>SLICK -- you either noticed the "Show Prev/Next patterns" thing in-code or saw my note and fixed it prior to (or without) comment!</blockquote>
That is, again, because OpenMPT searches through <b>pattern</b>, not through <b>orders</b>, and a pattern without an order obviously has no prev/next pattern. Since OpenMPT tries to find an ordner for the currently searched pattern now, the prev/next pattern can now be seen again, as long as you're not switching sequences.

<blockquote>Reg'd comment 627 -- do you think such would make a useful feature?</blockquote>
Dunno, I think the existing multi-window functionality can already be used for that if you really need it.

Issue History

Date Modified Username Field Change
2012-03-07 21:41 christofori New Issue
2012-03-07 22:33 Saga Musix Note Added: 0000623
2012-03-07 22:33 Saga Musix Note Edited: 0000623
2012-03-07 22:41 christofori Note Added: 0000624
2012-03-07 22:43 Saga Musix Note Added: 0000625
2012-03-07 22:43 Saga Musix Assigned To => Saga Musix
2012-03-07 22:43 Saga Musix Status new => assigned
2012-03-07 22:43 Saga Musix Target Version => OpenMPT (upgrade first)
2012-03-07 22:44 christofori Note Added: 0000626
2012-03-07 22:50 christofori Note Added: 0000627
2012-03-07 22:51 christofori Note Edited: 0000627
2012-03-07 22:54 christofori Note Edited: 0000627
2012-03-07 22:55 Saga Musix Note Added: 0000628
2012-03-07 23:22 Saga Musix Note Added: 0000635
2012-03-07 23:22 Saga Musix Status assigned => feedback
2012-03-08 04:33 christofori Note Added: 0000638
2012-03-08 04:33 christofori Status feedback => assigned
2012-03-08 04:37 christofori Note Edited: 0000638
2012-03-08 04:52 christofori Note Edited: 0000638
2012-03-08 04:58 christofori Note Added: 0000639
2012-03-08 11:13 Saga Musix Note Added: 0000643
2012-03-08 11:14 Saga Musix Status assigned => resolved
2012-03-08 11:14 Saga Musix Resolution open => fixed