View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000189 | OpenMPT | User Interface | public | 2011-09-19 13:58 | 2012-05-14 14:04 |
Reporter | harbinger | Assigned To | Saga Musix | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | Windows | OS | XP | OS Version | SP3? |
Product Version | OpenMPT 1.19.03.00 (upgrade first) | ||||
Target Version | OpenMPT 1.20.01.00 (upgrade first) | Fixed in Version | OpenMPT 1.20.01.00 (upgrade first) | ||
Summary | 0000189: Undo prevents Step Note Navigation | ||||
Description | After using Undo (i've set my shortcut to Ctrl-Z), subsequent keypress note entries that would normally move to the next pattern do not navigate, moving instead to the last row as if Continuous Scroll were not set. It seems to only occur if the Undo occurred on an unseen pattern than the one showing. | ||||
Steps To Reproduce |
| ||||
Additional Information | I thought the problem might be that the cursor may not realize it's in another pattern, and when it goes to scroll after navigation, it's finding it's not in the correct pattern so the scroll function is simply ignored. However, it seems you could reset the cursor then by clicking in the pattern where you're at (where the Undo took place). This, however, is not true -- clicking anywhere in the pattern does not reset the cursor. | ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | I think so. I've only recently narrowed down the cause. | ||||
Tested code revision (in case you know it) | |||||
This happens because the undo buffer is agnostic of the order list. So when you change to another pattern by undoing previous actions, the order of this pattern is unknown. I'll change this so that OpenMPT searched for any order in the current sequence containing that pattern, which should work as expected in most cases. |
|
Revision 1258 / OpenMPT 1.20.00.87 should fix this. It will not work properly if the same pattern is used twice in the order list, but I guess it's close enough. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2011-09-19 13:58 | harbinger | New Issue | |
2012-04-28 16:28 | Saga Musix | Assigned To | => Saga Musix |
2012-04-28 16:28 | Saga Musix | Status | new => assigned |
2012-04-28 16:31 | Saga Musix | Note Added: 0000701 | |
2012-04-28 16:42 | Saga Musix | Note Added: 0000702 | |
2012-04-28 16:42 | Saga Musix | Status | assigned => feedback |
2012-05-14 14:04 | Saga Musix | Status | feedback => resolved |
2012-05-14 14:04 | Saga Musix | Resolution | open => fixed |
2012-05-14 14:04 | Saga Musix | Fixed in Version | => OpenMPT 1.20.01.00 (upgrade first) |
2012-05-14 14:04 | Saga Musix | Target Version | => OpenMPT 1.20.01.00 (upgrade first) |