View Issue Details

IDProjectCategoryView StatusLast Update
0001870OpenMPTGeneralpublic2025-03-18 07:37
Reportercs127 Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Platformx86 / x64OSWindows / WineOS Versionany
Product VersionOpenMPT 1.32.00.* (current testing) 
Summary0001870: Unable to unmap instruments from MIDI library
Description

If an instrument is mapped in the MIDI library, unmapping it will only remove it temporarily. It'll be back after restarting MPT.

Additional Information

This makes it impossible to unmap the default MIDI library configuration on Windows, unless you remove gm.dls from the Windows drivers folder.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)23045

Activities

Saga Musix

Saga Musix

2025-03-17 13:42

administrator   ~0006328

Yes, that works as designed, to keep MIDI import always working. Is there a problem with this?

cs127

cs127

2025-03-17 13:51

reporter   ~0006329

Last edited: 2025-03-17 13:54

The most obvious use case for keeping them unmapped is to have blank samples when importing MIDIs. Maybe it's a bit of a niche use case, but whatever.

But if it's intentional, why is there be an unmap option in the first place, if it'll be remapped anyway?

keep MIDI import always working

Sure, but Wine doesn't come with gm.dls, so MIDI import is already "broken" by default on a stock Wine configuration.

Saga Musix

Saga Musix

2025-03-17 19:56

administrator   ~0006330

The most obvious use case for keeping them unmapped is to have blank samples when importing MIDIs. Maybe it's a bit of a niche use case, but whatever.

Is that an actual use case you have or are you just trying to figure out a way why someone might *possibly want the feature to work like that? Like, which concrete problem would this solve during MIDI import?

But if it's intentional, why is there be an unmap option in the first place, if it'll be remapped anyway?

Maybe it should be named "reset to default" and immediately revert to the default mapping (which doesn't need to be GM.DLS - the registry key for DirectMusic could be pointing to any other DLS file). Because as said, I don't see any useful, practical reason for a MIDI library item to be missing.

Sure, but Wine doesn't come with gm.dls, so MIDI import is already "broken" by default on a stock Wine configuration.

One system being broken doesn't imply that all other systems need to be broken as well.

cs127

cs127

2025-03-18 07:37

reporter   ~0006332

Is that an actual use case you have or are you just trying to figure out a way why someone might *possibly want the feature to work like that? Like, which concrete problem would this solve during MIDI import?

Maybe it should be named "reset to default" and immediately revert to the default mapping

Usually when I import MIDIs I want each instrument to have one blank sample, so I could then load a sample into it. I know I can just make a blank soundfont and use that, but that's a hacky solution.

Plus, if you add "reset to default", I don't see why it would be a problem to add proper unmapping too.
In mptrack.ini, you could store a special value for empty instrument keys, and fallback to the DirectMusic soundfont for missing keys.

Like I said, it's a niche use case, and it's not too important, so I understand if you don't want to add it, but please at least add "reset to default", since the current behaviour is weird.

Issue History

Date Modified Username Field Change
2025-03-17 09:16 cs127 New Issue
2025-03-17 13:42 Saga Musix Note Added: 0006328
2025-03-17 13:51 cs127 Note Added: 0006329
2025-03-17 13:54 cs127 Note Edited: 0006329
2025-03-17 19:56 Saga Musix Note Added: 0006330
2025-03-18 07:37 cs127 Note Added: 0006332