View Issue Details

IDProjectCategoryView StatusLast Update
0001860OpenMPTlibopenmptpublic2025-05-27 18:26
Reportermonstera Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Target VersionOpenMPT 1.32.01.00 / libopenmpt 0.8.0 (current stable)Fixed in VersionOpenMPT 1.32.01.00 / libopenmpt 0.8.0 (current stable) 
Summary0001860: MTM-Modules: format_pattern_row_channel_command returns '?' as effect command
Description

When calling format_pattern_row_channel_command, the returned effect is '?' instead of 'v' for volume because I only get '?' when there is a volume command at MTM modules.
You can test it with this module:
https://modarchive.org/index.php/index.php?request=view_by_moduleid&query=40689
Call (format_pattern_row_channel_command(0, 8, 1, 3); for the test.
But it´s the same with every MTM module. OpenMPT shows the effect name correctly.

Steps To Reproduce

Tested with version 0.7.12

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2025-02-08 15:58

administrator   ~0006306

This is unfortunately a currently limitation with how libopenmpt formats effects; if the format that the file would get imported as in OpenMPT doesn't support an effect (in this particular case, MTM files get imported as MODs in OpenMPT), then libopenmpt cannot show a proper effect letter. OpenMPT handles the volume column a bit differently compared to libopenmpt so that particular effect isn't a problem there, but other effects in non-native formats will also show up as "?", just like in OpenMPT. In the long run, we really need to find a way to show effect letters for effects that aren't native to OpenMPT's formats in libopenmpt patterns.

Saga Musix

Saga Musix

2025-05-27 18:26

administrator   ~0006365

This should be fixed in trunk (r23219) and the upcoming libopenmpt 0.8 (r23221).

Issue History

Date Modified Username Field Change
2025-02-07 23:31 monstera New Issue
2025-02-08 15:58 Saga Musix Note Added: 0006306
2025-05-27 18:24 Saga Musix Assigned To => Saga Musix
2025-05-27 18:24 Saga Musix Status new => assigned
2025-05-27 18:25 Saga Musix Target Version => OpenMPT 1.32.01.00 / libopenmpt 0.8.0 (current stable)
2025-05-27 18:26 Saga Musix Note Added: 0006365
2025-05-27 18:26 Saga Musix Status assigned => resolved
2025-05-27 18:26 Saga Musix Resolution open => fixed
2025-05-27 18:26 Saga Musix Fixed in Version => OpenMPT 1.32.01.00 / libopenmpt 0.8.0 (current stable)