View Issue Details

IDProjectCategoryView StatusLast Update
0001852OpenMPTUser Interfacepublic2024-12-23 16:51
Reportermakepost Assigned ToSaga Musix  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status resolvedResolutionfixed 
Platformx86 / x64OSWineOS Version(version plz)
Product VersionOpenMPT 1.31.12.00 / libopenmpt 0.7.11 (upgrade first) 
Target VersionOpenMPT 1.31.14.00 / libopenmpt 0.7.13 (upcoming stable)Fixed in VersionOpenMPT 1.31.14.00 / libopenmpt 0.7.13 (upcoming stable) 
Summary0001852: Insert cue point on Shift+1 - Shift-9 if doesn't exist yet
Description

When slicing samples, playing cue points with Shift+1 - Shift-9 is very useful. Each of these key shortcuts plays the sample beginning at the cue point if the point already exists, and does nothing if it doesn't. Can the same shortcut insert the cue point at the playback position if the point doesn't exist yet? I see this workflow on Akai MPC devices, where the first tap of the pad inserts a cue, and the next taps play it.

Additional Information

On a very crude level, I see the implementation as following: in CViewSample::OnCustomKeyMsg, add an else branch to if(offset < sample.nLength), using a copy of the content of CViewSample::OnSetCuePoint with... something in place of m_dwMenuParam. Sorry I didn't figure out on my own how to get current playback position.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2024-12-23 16:50

administrator   ~0006284

That's a nice idea. Added in r22605. Note that this will only work (by design) if a single note is being previewed; if you are playing a chord, the shortcuts won't do anything.

Issue History

Date Modified Username Field Change
2024-12-23 15:41 makepost New Issue
2024-12-23 16:49 Saga Musix Assigned To => Saga Musix
2024-12-23 16:49 Saga Musix Status new => assigned
2024-12-23 16:50 Saga Musix Note Added: 0006284
2024-12-23 16:51 Saga Musix Status assigned => resolved
2024-12-23 16:51 Saga Musix Resolution open => fixed
2024-12-23 16:51 Saga Musix Fixed in Version => OpenMPT 1.31.14.00 / libopenmpt 0.7.13 (upcoming stable)
2024-12-23 16:51 Saga Musix Target Version => OpenMPT 1.31.14.00 / libopenmpt 0.7.13 (upcoming stable)