View Issue Details

IDProjectCategoryView StatusLast Update
0001843OpenMPTGeneralpublic2024-11-29 22:37
Reporterzersal Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.31.12.00 / libopenmpt 0.7.11 (upgrade first) 
Target VersionOpenMPT 1.31.13.00 / libopenmpt 0.7.12 (current stable)Fixed in VersionOpenMPT 1.31.13.00 / libopenmpt 0.7.12 (current stable) 
Summary0001843: Don't clear modified flag when saving as copy
Description

It shouldn't clear the flag when saving a copy, since the currently open file is still modified after that.

TagsNo tags attached.
Attached Files
Moddoc.cpp.patch (486 bytes)   
Index: OpenMPT/mptrack/Moddoc.cpp
===================================================================
--- OpenMPT/mptrack/Moddoc.cpp	(revision 22348)
+++ OpenMPT/mptrack/Moddoc.cpp	(working copy)
@@ -557,7 +557,8 @@
 	}
 	if(OnSaveDocument(saveFileName, setPath))
 	{
-		SetModified(false);
+		// don't clear modified flag when saving as copy
+		if(setPath) SetModified(false);
 		m_SndFile.m_SongFlags.reset(SONG_IMPORTED);
 		m_bHasValidPath = true;
 		m_ShowSavedialog = false;
Moddoc.cpp.patch (486 bytes)   
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2024-11-29 22:36

administrator   ~0006229

Thanks for taking the time to not only report but even fix the bug! Fixed in r22349.

Issue History

Date Modified Username Field Change
2024-11-29 21:59 zersal New Issue
2024-11-29 21:59 zersal File Added: Moddoc.cpp.patch
2024-11-29 22:36 Saga Musix Assigned To => Saga Musix
2024-11-29 22:36 Saga Musix Status new => assigned
2024-11-29 22:36 Saga Musix Note Added: 0006229
2024-11-29 22:37 Saga Musix Status assigned => resolved
2024-11-29 22:37 Saga Musix Resolution open => fixed
2024-11-29 22:37 Saga Musix Product Version => OpenMPT 1.31.12.00 / libopenmpt 0.7.11 (upgrade first)
2024-11-29 22:37 Saga Musix Fixed in Version => OpenMPT 1.31.13.00 / libopenmpt 0.7.12 (current stable)
2024-11-29 22:37 Saga Musix Target Version => OpenMPT 1.31.13.00 / libopenmpt 0.7.12 (current stable)