View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001843 | OpenMPT | General | public | 2024-11-29 21:59 | 2024-11-29 22:37 |
| Reporter | zersal | Assigned To | Saga Musix | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Product Version | OpenMPT 1.31.12.00 / libopenmpt 0.7.11 (current stable) | ||||
| Target Version | OpenMPT 1.31.13.00 / libopenmpt 0.7.12 (upcoming stable) | Fixed in Version | OpenMPT 1.31.13.00 / libopenmpt 0.7.12 (upcoming stable) | ||
| Summary | 0001843: Don't clear modified flag when saving as copy | ||||
| Description | It shouldn't clear the flag when saving a copy, since the currently open file is still modified after that. | ||||
| Tags | No tags attached. | ||||
| Attached Files | Moddoc.cpp.patch (486 bytes)
Index: OpenMPT/mptrack/Moddoc.cpp
===================================================================
--- OpenMPT/mptrack/Moddoc.cpp (revision 22348)
+++ OpenMPT/mptrack/Moddoc.cpp (working copy)
@@ -557,7 +557,8 @@
}
if(OnSaveDocument(saveFileName, setPath))
{
- SetModified(false);
+ // don't clear modified flag when saving as copy
+ if(setPath) SetModified(false);
m_SndFile.m_SongFlags.reset(SONG_IMPORTED);
m_bHasValidPath = true;
m_ShowSavedialog = false;
| ||||
| Has the bug occurred in previous versions? | |||||
| Tested code revision (in case you know it) | |||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-11-29 21:59 | zersal | New Issue | |
| 2024-11-29 21:59 | zersal | File Added: Moddoc.cpp.patch | |
| 2024-11-29 22:36 | Saga Musix | Assigned To | => Saga Musix |
| 2024-11-29 22:36 | Saga Musix | Status | new => assigned |
| 2024-11-29 22:36 | Saga Musix | Note Added: 0006229 | |
| 2024-11-29 22:37 | Saga Musix | Status | assigned => resolved |
| 2024-11-29 22:37 | Saga Musix | Resolution | open => fixed |
| 2024-11-29 22:37 | Saga Musix | Product Version | => OpenMPT 1.31.12.00 / libopenmpt 0.7.11 (current stable) |
| 2024-11-29 22:37 | Saga Musix | Fixed in Version | => OpenMPT 1.31.13.00 / libopenmpt 0.7.12 (upcoming stable) |
| 2024-11-29 22:37 | Saga Musix | Target Version | => OpenMPT 1.31.13.00 / libopenmpt 0.7.12 (upcoming stable) |
