| Description | The fact that GetLength re-implements most of the module playback logic is a constant source of bugs. It would be great if we could use the regular module playback logic for the task of seeking and song length calculation, as this would avoid several sources for errors, and it would make the "seeking with sample sync" feature more precise as well.
The main issue is, of course, that regular song playback changes global song state. For regular sample-based playback, just making all playback logic take a custom PlayState object instead of operating on m_PlayState would not be a big deal; various functions already do this anyway because they are shared between GetLength and regular playback code. The main issue that remains is OPL and VST processing: We essentially need a guarantee that there's nothing in the playback code that ever touches those global resources. Maybe we could move the m_opl object into the PlayState struct, so song length retrieval works on its own, local OPL emulator. Plugins are a bit more challenging though. |
|---|
