View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001777OpenMPTGeneralpublic2024-05-09 19:162024-05-09 23:25
Reportercs127 Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
PlatformanyOSWindows/WineOS Versionany
Product VersionOpenMPT 1.31.06.00 / libopenmpt 0.7.6 (upgrade first) 
Summary0001777: Blank commands with nonzero parameters are lost when saving an IT file.
Description

S3M and IT's blank commands with nonzero parameters (which are converted to CMD_DUMMY upon load) are lost when saving the file as IT, but preserved in S3M.
I don't know which of those is the intended behaviour, but I would like the command to be preserved (in both formats).

I assume the fix is as simple as replacing

if (command) b |= 8;

with

if (command || param) b |= 8;

in soundlib/Load_it.cpp

I could have made a pull request, but I don't have a Windows environment to compile and test it on, so I made this bug report instead just to be safe.

Steps To Reproduce
  1. load an IT file that has a blank command with a nonzero parameter (you can make one with Impulse Tracker)
  2. save and reopen the file, the commands will be gone

this does not occur in S3M.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2024-05-09 22:36

administrator   ~0005946

This is intentional - they are only preserved in S3M because they affect parameter memory (so removing them may modify playback). which is not the case in IT.
Saga Musix

Saga Musix

2024-05-09 23:25

administrator   ~0005947

(and actually these blank commands confuse the pattern loader in older OpenMPT versions (see r5580), so there's a pretty good reason to filter them out.)

Issue History

Date Modified Username Field Change
2024-05-09 19:16 cs127 New Issue
2024-05-09 22:36 Saga Musix Note Added: 0005946
2024-05-09 22:36 Saga Musix Status new => closed
2024-05-09 22:36 Saga Musix Resolution open => no change required
2024-05-09 23:25 Saga Musix Note Added: 0005947