View Issue Details

IDProjectCategoryView StatusLast Update
0001742OpenMPTGeneralpublic2024-02-12 22:52
Reporter02FD Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product VersionOpenMPT 1.31.04.00 / libopenmpt 0.7.3 (current stable) 
Summary0001742: When a module is appended to another module, samples mapped to multiple instruments are duplicated
Description

A small issue that can be a real headache when working with modules that use multiple envelopes for the same sample.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2024-01-25 17:38

administrator   ~0005829

Unfortunately this cannot really be solved easily because the code used for copying instruments from other modules is completely unaware of this. It would require a large rewrite (with added complexity) for little gain, especially when considering 0001744 as a potential alternative.

02FD

02FD

2024-01-25 18:39

reporter   ~0005831

To be fair it would be nice if the copy instrument routine always checked for duplicates automatically. Occasionally I import an instrument only to realize one of its samples was already present in the module.

Saga Musix

Saga Musix

2024-01-25 18:43

administrator   ~0005832

This can be a costly process (in the worst case, several GB of sample data would have to be scanned for identity), and it may not even always be what you wanted. For example you may absolutely want to create a second copy of an instrument in order to alter its samples. Always de-duplicating them doesn't sound like the right approach to me.

02FD

02FD

2024-02-12 22:51

reporter   ~0005841

Last edited: 2024-02-12 22:52

I meant to say this the other day, but that's a compelling point. I agree that the other issue I posted probably fixes this better.

Issue History

Date Modified Username Field Change
2024-01-25 01:00 02FD New Issue
2024-01-25 17:38 Saga Musix Note Added: 0005829
2024-01-25 18:39 02FD Note Added: 0005831
2024-01-25 18:43 Saga Musix Note Added: 0005832
2024-02-12 22:51 02FD Note Added: 0005841
2024-02-12 22:52 02FD Note Edited: 0005841