View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001706||OpenMPT||File Format Support||public||2023-05-20 22:36||2023-05-21 13:12|
|Reporter||stgiga||Assigned To||Saga Musix|
|Product Version||OpenMPT 1.31.02.00 / libopenmpt 0.7.1 (current stable)|
|Target Version||OpenMPT 1.31.03.00 / libopenmpt 0.7.2 (upcoming stable)|
|Summary||0001706: Shortened drum key envelopes in SF2 instruments|
When I updated to either version of 1.31.x to test out the new SoundFont support updates with my JummBox SoundFont (http://musical-artifacts.com/2722), I ran into a bug where after MIDI import, the drums would not play at all, even though their samples were imported and are there. This was not a problem on 1.30.
|Steps To Reproduce|
1 (optional, does not make a difference). Remove GM.dls from the list of banks.
The drums won't play, but in 1.30.x it works.
This bug is one that affects SF2 use, and it's a regression for sure. It reminds me of a similar bug in 1.29.x versions as far as I can remember. Note that the SF2 I linked was specifically designed to remain compatible with OpenMPT. It works great in 1.28.10 and ALL 1.30.x versions. I presently main 1.30.12 in waiting for this fix. It works there.
|Tags||No tags attached.|
|Has the bug occurred in previous versions?||Yes|
|Tested code revision (in case you know it)|
From what I can see, the drums do play, but due to the particular shape of their envelopes, they only play for a single tick. The sustain point was always disabled for drum keys, even after adding support for custom drum key envelopes in OpenMPT 1.31, which is why it was not a problem in older versions (they all just used a standard drum key envelope).
Please confirm that r19341 (soon available from https://builds.openmpt.org/builds/) fixes this.
They are no longer muted. However, the resulting notes are significantly shorter than in older OpenMPT versions or the SF2 played back in a dedicated SF2 player like BassMIDI.
Oh, the global zone's envelope was not applied to individual drum keys, instead it was expected that each drum key provides its own envelope settings. As of r19344, the envelope settings from the global zone should now be applied correctly.
|2023-05-20 22:36||stgiga||New Issue|
|2023-05-20 23:07||Saga Musix||Assigned To||=> Saga Musix|
|2023-05-20 23:07||Saga Musix||Status||new => assigned|
|2023-05-20 23:09||Saga Musix||Status||assigned => new|
|2023-05-20 23:09||Saga Musix||Note Added: 0005729|
|2023-05-20 23:09||Saga Musix||Status||new => feedback|
|2023-05-20 23:09||Saga Musix||Target Version||=> OpenMPT 1.31.03.00 / libopenmpt 0.7.2 (upcoming stable)|
|2023-05-21 00:04||stgiga||Note Added: 0005730|
|2023-05-21 00:04||stgiga||Status||feedback => assigned|
|2023-05-21 12:32||Saga Musix||Status||assigned => feedback|
|2023-05-21 12:32||Saga Musix||Note Added: 0005731|
|2023-05-21 13:12||Saga Musix||Summary||SoundFonts loaded in 1.31.x lose their drums that worked in 1.30.x => Shortened drum key envelopes in SF2 instruments|