View Issue Details

IDProjectCategoryView StatusLast Update
0001687OpenMPTUser Interfacepublic2024-09-19 17:33
Reporterdem1 Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.30.11.00 / libopenmpt 0.6.9 (upgrade first) 
Target VersionOpenMPT 1.32 / libopenmpt 0.8 (goals)Fixed in VersionOpenMPT 1.32 / libopenmpt 0.8 (goals) 
Summary0001687: Use modern folder picker dialog on Windows Vista and later
Description

This modal appears when scanning a folder for plugins. See attached screenshot.

BrowseForFolder::Show (line 206 FileDialog.cpp) unconditionally calls SHBrowseForFolder.
Windows Vista and later support a folder picker dialog with better UX.
Per MSDN:

"For Windows Vista or later, it is recommended that you use IFileDialog with the FOS_PICKFOLDERS option rather than the SHBrowseForFolder function. This uses the Open Files dialog in pick folders mode and is the preferred implementation."

TagsNo tags attached.
Attached Files
Capture.PNG (10,805 bytes)   
Capture.PNG (10,805 bytes)   
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Relationships

related to 0001408 new Migrate MessageBoxes to Vista TaskDialog 

Activities

Saga Musix

Saga Musix

2023-04-07 20:14

administrator   ~0005656

I'm not really a fan of the modern UI (I'm very much used to the tree structure), so this would only be added as an option.

Saga Musix

Saga Musix

2024-09-19 17:28

administrator   ~0006063

Implemented in r21643. Old style folder browser can be restored by toggling the hidden setting Display.UseOldStyleFolderBrowser.

manx

manx

2024-09-19 17:29

administrator   ~0006064

Do we know if this is supported by all Wine versions that we support?

Saga Musix

Saga Musix

2024-09-19 17:29

administrator   ~0006065

We know that last time I tested, Wine's IFileDialog implementation was essentially broken beyond any use, so we never use IFileDialog on Wine.

manx

manx

2024-09-19 17:33

administrator   ~0006066

Ah, I had missed the Wine check :)

Issue History

Date Modified Username Field Change
2023-04-07 17:29 dem1 New Issue
2023-04-07 17:29 dem1 File Added: Capture.PNG
2023-04-07 19:46 manx Relationship added related to 0001408
2023-04-07 19:46 manx Target Version => OpenMPT 1.32 / libopenmpt 0.8 (goals)
2023-04-07 20:14 Saga Musix Note Added: 0005656
2024-09-19 17:25 Saga Musix Assigned To => Saga Musix
2024-09-19 17:25 Saga Musix Status new => assigned
2024-09-19 17:28 Saga Musix Note Added: 0006063
2024-09-19 17:28 Saga Musix Status assigned => resolved
2024-09-19 17:28 Saga Musix Resolution open => fixed
2024-09-19 17:28 Saga Musix Fixed in Version => OpenMPT 1.32 / libopenmpt 0.8 (goals)
2024-09-19 17:29 manx Note Added: 0006064
2024-09-19 17:29 Saga Musix Note Added: 0006065
2024-09-19 17:33 manx Note Added: 0006066