0001687: Use modern folder picker dialog on Windows Vista and later

ID	Project	Category	View Status	Date Submitted	Last Update

0001687	OpenMPT	User Interface	public	2023-04-07 17:29	2023-04-07 20:14

Reporter	dem1	Assigned To
Priority	normal	Severity	minor	Reproducibility	always
Status	new	Resolution	open
Platform	x64	OS	Windows	OS Version	10
Product Version	OpenMPT 1.30.11.00 / libopenmpt 0.6.9 (upgrade first)
Target Version	OpenMPT 1.32 / libopenmpt 0.8 (goals)

Summary	0001687: Use modern folder picker dialog on Windows Vista and later
Description	This modal appears when scanning a folder for plugins. See attached screenshot. BrowseForFolder::Show (line 206 FileDialog.cpp) unconditionally calls SHBrowseForFolder. Windows Vista and later support a folder picker dialog with better UX. Per MSDN: "For Windows Vista or later, it is recommended that you use IFileDialog with the FOS_PICKFOLDERS option rather than the SHBrowseForFolder function. This uses the Open Files dialog in pick folders mode and is the preferred implementation."
Tags	No tags attached.

Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Date Modified	Username	Field	Change
2023-04-07 17:29	dem1	New Issue
2023-04-07 17:29	dem1	File Added: Capture.PNG
2023-04-07 19:46	manx	Relationship added	related to 0001408
2023-04-07 19:46	manx	Target Version	=> OpenMPT 1.32 / libopenmpt 0.8 (goals)
2023-04-07 20:14	Saga Musix	Note Added: 0005656

dem1 2023-04-07 17:29 reporter	Capture.PNG (10,805 bytes) Capture.PNG (10,805 bytes)

Saga Musix 2023-04-07 20:14 administrator ~0005656	I'm not really a fan of the modern UI (I'm very much used to the tree structure), so this would only be added as an option.