View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000167OpenMPTGeneralpublic2011-09-02 18:522011-09-13 20:00
Reporterharbinger Assigned ToSaga Musix  
PriorityhighSeveritycrashReproducibilityalways
Status closedResolutionno change required 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.19.01.00 (upgrade first) 
Summary0000167: Compatibility Export crashes when saving
Description

While doing a compat export on a track, MPT hung up before the Save dialog had been closed. The original track was an MPTM track first composed in MPT 1.17.02.48 and last edited on 1.19.01. Here i converted it to IT and switched the mix level mode to Compatible as well as the playback mode. After pressing OK, the Save dialog stayed and MPT got hung up. I terminated the MPT thread, opened the application again, and took a look to see if the compatible IT track had been saved properly. MPT apparently had saved the list of pattern indexes, but lost (or did not get to) the note and channel data.
After other Compat Exports, all unsuccessful, I then tried to change the MPTM to IT and simply Save As the file using the same compat modes described above. Again MPT hung up. I then tried without the compat modes set, resulting in the same kind of crash. The save included the pattern, sample, and channel data, but lost the note data.
I then tried another Save As without the compatible modes in mix levels and playback. Again, it hung up.
I was eventually forced to convert the file to XM, since i tried everything i could to convert the track to IT. It did save to a Compat XM, but of course, i've lost alot of my features. (This is a project i and another composer are starting to work on, and i wanted to be in IT mode to preserve the features.)

Additional Information

Notes:
Not sure if any of these observations are important, but i thought i'd mention them without knowing if they could be a factor.

No plugins were used.
No cleanup was ever done.
There is no pattern 0 in the list, and the patterns are not in order.
The hacks in the original MPTM were shown to be: Pattern Names, Channel names, Instrument extensions, and "incorrect" mix levels.

I have saves for each of the scenarios described above, but i'm only allowed to upload 1 at less than half a MB (the original MPTM is over 1 MB). If anyone needs any of the saves for debugging purposes let me know where to send it and i shall.

TagsNo tags attached.
Has the bug occurred in previous versions?No
Tested code revision (in case you know it)

Activities

jmkz

jmkz

2011-09-02 19:25

reporter   ~0000386

What about using v1.19.03? Is this bug still present in v1.19.03?
jmkz

jmkz

2011-09-02 20:23

reporter   ~0000387

Last edited: 2011-09-02 20:24

I cannot reproduce the bug. I have created an v1.17.02.48 module and worked something and saved, then loaded into v1.19.01 and reproducing your steps but still happen nothing. Please send me you module. Check if happen on 1.19.03 or 1.20 dev build. Hope one of them work.
harbinger

harbinger

2011-09-02 20:27

reporter   ~0000388

I hate updating unless there's more than a few major changes (features) to the code, because i use my own PE bitmap and it's a PITA to ResEdit every new version that comes out. 1.19.01 works fine for me now, and i was planning on updating to 1.20 when it was ready, but not until then...

If it's fixed in 1.19.03, i'll upgrade. Or if it's KNOWN why 19.01 would crash MPT on an export of a 17.2.48 track....
harbinger

harbinger

2011-09-02 20:29

reporter   ~0000389

Will do.
Saga Musix

Saga Musix

2011-09-02 22:09

administrator   ~0000390

Last edited: 2011-09-02 22:17

There was a bug in the save code in either 1.19.01 or 1.19.02 for IT files which should only trigger if a sample index higher than the number of samples is referenced in an instrument's note map, but that doesn't seem to be the case in the file you sent me. Nevertheless, I cannot reproduce the bug in either 1.19.01 nor the latest SVN version.

One other note: You might not like updating, but developers don't like pursuing bug reports that were only tested on outdated versions even more! 1.19.02 brought some new features, and 1.19.03 was explicitely a bugfix build, so you really should try stuff like this with 1.19.03 first, as there were quite a few severe bugs that I have fixed in that version. And it's not like new versions coming out every week, not even every month...
harbinger

harbinger

2011-09-08 19:43

reporter   ~0000435

Touche!

I will see if 1.19.03 will export the file, esp. since you specifically know about save bugs from 1.19.01.

I'll let you know what i find...
harbinger

harbinger

2011-09-13 19:45

reporter   ~0000463

This bug is corrected by 1.19.03. I was able to export a Compat version IT properly and can now continue with my project. This issue is resolved.

Thanks for all your help!

Issue History

Date Modified Username Field Change
2011-09-02 18:52 harbinger New Issue
2011-09-02 19:25 jmkz Note Added: 0000386
2011-09-02 20:23 jmkz Note Added: 0000387
2011-09-02 20:24 jmkz Note Edited: 0000387
2011-09-02 20:27 harbinger Note Added: 0000388
2011-09-02 20:29 harbinger Note Added: 0000389
2011-09-02 22:09 Saga Musix Note Added: 0000390
2011-09-02 22:17 Saga Musix Note Edited: 0000390
2011-09-08 19:43 harbinger Note Added: 0000435
2011-09-13 19:45 harbinger Note Added: 0000463
2011-09-13 20:00 Saga Musix Status new => closed
2011-09-13 20:00 Saga Musix Assigned To => Saga Musix
2011-09-13 20:00 Saga Musix Resolution open => no change required