View Issue Details

IDProjectCategoryView StatusLast Update
0001657OpenMPTFeature Requestpublic2023-01-28 16:14
ReporterExhale Assigned To 
Status resolvedResolutionfixed 
Product VersionOpenMPT / libopenmpt 0.6.7 (upgrade first) 
Target VersionOpenMPT / libopenmpt 0.6.8 (upgrade first)Fixed in VersionOpenMPT / libopenmpt 0.6.8 (upgrade first) 
Summary0001657: Initial instrument cutoff no longer affects OPL instruments

For the OPL instruments I had a trick that I used to use, which I guess has been considered a glitch and patched out now, unless the change has only happened to 64 bit versions of OMPT.

What used to happen as far as I have been able to make out was this:
if you adjusted the cutoff of an OPL whether in the instrument tab or in the pattern it would change the volume of the second oscillator, but it was only making that change to OPLs without the additive synth clicked. As a opl version of the cutoff it wasnt accurate to an actual cutoff, granted, but I got a lot of use out of it, creating great random variation in the OPL instruments I made. It is still working with the ZXX commands in patterns, but doesnt work with the random variation slider.

For the request I would like to propose something like this as an official part of the way opl instruments are incorporated into the effects which arent presently doing anything to opl instruments.

I know the SDX commands are applying delays as they should... the ZXX effects are still applying the 'glitch' I just talked about which is very useful, but I am sure we can find effects that are presently not being applied to OPL instruments such as the volume, reso random variation sliders, and other things in the pattern.

I propose, for both kinds of OPL, in the instrument tab :
the volume randomizer effect the volume of the whole instrument
the cutoff randomizer effects the volume of the second oscillator only (like it used to work, but now for additive opls too)
the resonance randomizer effects the volume of the first oscillator only (which would end up being a second volume randomizer I guess for the opls that dont have additive synth clicked)

In fact, maybe a whole different design for the instruments attached to OPLs would be warrented since so much of them is very different from sample instruments - and thus we could have randomisers for all the sliders in the OPL sample tab and they would be marked for what they do.

and for the effects on the pattern :
ZXX remain a way to adjust the second osc
vxx and other volume commands stay as they are obviously
HXX vibrato could switch the vibrato button on and off
IXX could switch the tremelo button on and off
OXX could apply to the attack rates of both oscillators O00-O7F would be the first osc and O80-OFF could be the second osc
QXX it would be great to get retrigger on OPLs but I am sure that obvious change has a good reason for not being in OMPT yet

These are just some ideas, and I am sure you guys can figure out better ways to impliment these kinds of controls from within the pattern than me and guaranteed you guys know more about which effects do what to the OPL instruments than I do, the only one I know is the ZXX and I am grateful to have that at least.

Maybe this can be an idea pool for what pattern effects should do what... since there are a heck of a lot, and it would be useful to have (temporary) control over those sliders from within the patterns.

Either way I am simply brainstorming here and I hope the ideas are welcome. I feel like if we had more control over those sliders it would really help create variation in our tunes without having to make separate OPL instruments for each variation.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)


Saga Musix

Saga Musix

2023-01-28 15:53

administrator   ~0005518

For the OPL instruments I had a trick that I used to use, which I guess has been considered a glitch and patched out now, unless the change has only happened to 64 bit versions of OMPT.

Generally we do not simply remove behaviour that previously worked just fine. In particular if we do, we would mention so in the changelog and the wiki / manual would be updated to no mention that behaviour anymore. So to be clear, the fact that cutoff doesn't work on OPL instruments in OpenMPT is a bug and not an intentional behaviour change.

The rest of the issue body is, once again, way too verbose and conflates too many things into a single issue. As I have told you before, it's really hard to work with these long issues. Please consider: If you need more than two or three paragraphs to explain what you want, it's most likely too much information and needs to be split into independent issues or unnecessary information needs to be removed.

Saga Musix

Saga Musix

2023-01-28 16:14

administrator   ~0005519

The problem with instrument cutoff is now fixed in r18667.

I am not going to keep this issue open for the rest of the things you wrote. As I said, there is just way too much going on in this issue description for a single issue. "Wishlist issues" that describe multiple things you want to be changed about what is perceived to be a single feature never work, because we usually cannot implement all of those things at the same time. That being said, all of the commands you mentioned, apart from Oxx do work with OPL instruments (though Qxy does not work the way you would expect, maybe), so there is no point in changing their behaviour. That said, being able to control more OPL parameters, if it is ever going to happen, will not be done by repurposing existing commands. It's more likely that MIDI macros or dedicated commands will be used for that.

Issue History

Date Modified Username Field Change
2023-01-28 15:30 Exhale New Issue
2023-01-28 15:53 Saga Musix Note Added: 0005518
2023-01-28 16:14 Saga Musix Status new => resolved
2023-01-28 16:14 Saga Musix Resolution open => fixed
2023-01-28 16:14 Saga Musix Fixed in Version => OpenMPT / libopenmpt 0.6.8 (upgrade first)
2023-01-28 16:14 Saga Musix Target Version => OpenMPT / libopenmpt 0.6.8 (upgrade first)
2023-01-28 16:14 Saga Musix Summary feature request - More control over OPLs within the instrument tab and using code in patterns => Initial instrument cutoff no longer affects OPL instruments
2023-01-28 16:14 Saga Musix Note Added: 0005519