View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001650||OpenMPT||General||public||2023-01-11 13:52||2023-03-21 15:13|
|Reporter||Exhale||Assigned To||Saga Musix|
|Product Version||OpenMPT 1.31.00.* (current testing)|
|Summary||0001650: Freeze when updating soundfont search filter|
I said I would be back and since the last topic was closed I decided I would put this in it's own thing.
|Steps To Reproduce|
1 - have a lot of sound fonts and samples in your instrument library.
(I have managed to get ompt to crash at the first new search, and I have managed to have it survive long enough for me to search a few samples and soundfonts before crashing, but it always crashes if I do this)
wow this dmp file is 150 meg :o, at least the 7z version is 30meg.
|Tags||No tags attached.|
|Has the bug occurred in previous versions?||n/a|
|Tested code revision (in case you know it)|
We need to know the exact version of OpenMPT you're using (upper-right corner of the About dialog) to be able to do anything with that memory dump.
OpenMPT (amd64 (64 bit))
There it is
Apparently the Windows-internal tree view code gets stuck in an infinite loop when trying to expand some tree view nodes. Similar to this problem apparently https://social.msdn.microsoft.com/Forums/en-US/3fd6c4a2-b5c7-4334-b11a-e909b11e8bdc/quottreeviewsortquot-stuck-under-windows-vista-?forum=netfxbcl (at least the hang is in the same function)
alright, if you need anything from me, just ask.
I can reproduce it locally now after adding a few more soundfonts to the tree and typing slowly. The only obvious fix that I see at the moment is no longer trying to expand the child folders in soundfonts, which is probably rather annoying when refining a search because every newly typed character will collapse all the soundfont sub-folders again.
Ok. Then it is a good thing we caught this before putting the feature into a stable release, I am glad I could help in a little way. Good luck Saga and the rest of whomever might be capable and interested in looking into this, and thank you.
Last edited: 2023-01-11 20:52
Apparently the bug goes deeper than just child node expansion. Deleting items can also cause the hang, so just disabling the auto-expansion of bank folders doesn't fix anything. Right now I don't really have any idea how to approach this problem. Apparently several people have found similar problems before when using tree views but the component has stayed broken since at least Windows Vista!
Without knowing exactly what is broken, my best guess is that in both cases, the hang happens when calculating the visual size of the tree and whether scrollbars are needed - similar to issue 0001490.
Ok after a lot of thought, I my final thought on it is we are going to have to work around it somehow since microsoft has left that nonsense in since windows vista. Just wow that they give so few fucks about their buggy code that they just ignore it. I am sorry I have presented you with a problem that might actually be unsolvable, but I hope you find a creative work around.
I've tried everything I could think of, but there is simply no reliable workaround. As of r18670, soundfont search has been removed.
The only way this feature could find its way back would be to do the filtering in a completely different place outside of the treeview. But I don't see that happening anytime before the 1.31 release.
|2023-01-11 13:52||Exhale||New Issue|
|2023-01-11 14:12||Saga Musix||Note Added: 0005461|
|2023-01-11 15:09||Exhale||Note Added: 0005462|
|2023-01-11 17:22||Saga Musix||Note Added: 0005463|
|2023-01-11 17:56||Exhale||Note Added: 0005464|
|2023-01-11 18:21||Saga Musix||Note Added: 0005465|
|2023-01-11 19:36||Saga Musix||Assigned To||=> Saga Musix|
|2023-01-11 19:36||Saga Musix||Status||new => assigned|
|2023-01-11 19:52||Exhale||Note Added: 0005466|
|2023-01-11 20:49||Saga Musix||Note Added: 0005467|
|2023-01-11 20:52||Saga Musix||Note Edited: 0005467|
|2023-01-13 14:59||Saga Musix||Summary||the new soundfont and instrument library search crashes ompt => Freeze when updating soundfont search filter|
|2023-01-16 07:52||Exhale||Note Added: 0005490|
|2023-01-16 07:54||Exhale||Note Edited: 0005490|
|2023-01-16 08:07||Exhale||Note Edited: 0005490|
|2023-01-26 21:34||Saga Musix||Severity||major => block|
|2023-01-28 18:20||Saga Musix||Note Added: 0005520|
|2023-01-28 18:20||Saga Musix||Status||assigned => resolved|
|2023-01-28 18:20||Saga Musix||Resolution||open => fixed|
|2023-01-28 18:32||Saga Musix||Relationship added||related to 0001658|
|2023-03-21 15:12||Saga Musix||Relationship added||has duplicate 0001683|
|2023-03-21 15:13||Saga Musix||Relationship replaced||related to 0001683|