View Issue Details

IDProjectCategoryView StatusLast Update
0001641OpenMPTlibopenmptpublic2022-12-02 18:33
ReporterMrArnal Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.30.08.00 / libopenmpt 0.6.6 (upgrade first) 
Target VersionOpenMPT 1.30.09.00 / libopenmpt 0.6.7 (upgrade first)Fixed in VersionOpenMPT 1.30.09.00 / libopenmpt 0.6.7 (upgrade first) 
Summary0001641: Wrong S3M playback wihen ending with pattern loop
Description

S3M with a SB0-SBF loop on the last pattern doesn't loop back to the start of the song but restart the same pattern.
The playback control is set to "play.at_end", "continue".

Steps To Reproduce

Open https://modarchive.org/index.php?request=view_by_moduleid&query=69178 (Dune - Ketoprofein)

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2022-12-02 17:20

administrator   ~0005396

I am unable to confirm that the module plays restarts from the last pattern. However, the module doesn't reset its tempo to the default anyway when looping, so there's not much of a point in looping it. Not all modules are made to loop properly, and this module would not loop properly in ScreamTracker 3 either.

MrArnal

MrArnal

2022-12-02 17:48

reporter   ~0005397

The point is the song doesn't end when the pattern loop is over, libopenmpt doesn't return 0 samples but continue to play for 13 minutes.

Saga Musix

Saga Musix

2022-12-02 18:02

administrator   ~0005398

I see now some things in S3M-specific pattern loop handling a broken. Investigating...

Saga Musix

Saga Musix

2022-12-02 18:33

administrator   ~0005399

Fixed in r18176 (trunk) and r18177 (OpenMPT 1.30 / libopenmpt 0.6).

Issue History

Date Modified Username Field Change
2022-12-02 16:38 MrArnal New Issue
2022-12-02 17:20 Saga Musix Note Added: 0005396
2022-12-02 17:20 Saga Musix Assigned To => Saga Musix
2022-12-02 17:20 Saga Musix Status new => feedback
2022-12-02 17:48 MrArnal Note Added: 0005397
2022-12-02 17:48 MrArnal Status feedback => assigned
2022-12-02 18:02 Saga Musix Note Added: 0005398
2022-12-02 18:02 Saga Musix Severity major => minor
2022-12-02 18:33 Saga Musix Note Added: 0005399
2022-12-02 18:33 Saga Musix Status assigned => resolved
2022-12-02 18:33 Saga Musix Resolution open => fixed
2022-12-02 18:33 Saga Musix Fixed in Version => OpenMPT 1.30.09.00 / libopenmpt 0.6.7 (upgrade first)
2022-12-02 18:33 Saga Musix Target Version => OpenMPT 1.30.09.00 / libopenmpt 0.6.7 (upgrade first)