View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001623 | OpenMPT | User Interface | public | 2022-08-12 17:02 | 2022-08-14 14:14 |
Reporter | cs127 | Assigned To | |||
Priority | low | Severity | feature | Reproducibility | always |
Status | new | Resolution | open | ||
Platform | x86 / x64 | OS | Any | ||
Product Version | OpenMPT 1.31.00.* (old testing) | ||||
Summary | 0001623: [Feature request] FontDot for built-in fonts | ||||
Description | I have set the I know it's not possible to support every character (because the font bitmap only has the few characters necessary to draw notes, numbers, and commands letters), but it would be nice to still be able to set the FontDot for the characters that are in the bitmap, like how the same thing is done for custom note names in tunings. | ||||
Steps To Reproduce |
| ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | Yes | ||||
Tested code revision (in case you know it) | 17715 | ||||
related to | 0001114 | new | Rewrite pattern view drawing |
There's quite a few reasons why this cannot really work:
As a consequence, I cannot see how to implement this in a way which doesn't need to introduce at a handful of new settings or so (font, font size, cutout offset for the character, target position for the character). This is not feasible for such a small feature. |
|
"not available by using a custom font"? I don't really understand what you mean by that. when I said "custom font" I was referring to a user-chosen font, like a TrueType font, as opposed to the built-in font.
again, I don't know what you mean by "integrating unknown fonts" What I meant is to have the FontDot option not only affect user-chosen fonts, but also the built-in fonts. Basically, all I want is that when I set the FontDot option to an empty space character, I want the dots in the pattern editor to be shown as empty spaces, not only when using fonts installed on Windows/Wine (e.g. TrueType fonts), but also OpenMPT's built-in fonts. And if the FontDot is set to characters that aren't supported by the built-in fonts, like Let me know if I misunderstood anything. |
|
What I mean is that there is no custom font configuration available when using default pattern fonts. A new UI workflow for being able to pick a font for this single letter would have to be implemented.
As said, everything about the built-in fonts is manually crafted, which allows them to take up less space. For example there is no space available below the baseline (cf. https://upload.wikimedia.org/wikipedia/commons/3/39/Typography_Line_Terms.svg) because our font essentially just consists of uppercase letters and digits. This makes it pretty much impossible to merge any font with unknown proportions into the same bitmap without looking completely out-of-place, unless of course we give the user the option to manually specify a cutout area from where to copy the character and where to paste it into in our bitmap, which would be a completely overblown solution to this problem. The only really viable soltution is custom bitmap fonts that can be provided by the user. |
|
I never said anything about merging fonts. I really don't know if I'm not understanding what you're talking about, or if you misunderstood the point of this feature request. I just want the For characters that aren't in the built-in font, just don't draw them, like how characters like If that's not easy to implement, it's fine. I just want to make sure that you understand what I'm talking about. Thanks for your quick responses btw. |
|
Well, nevermind. After looking at the source code, I think I can see why it might be hard to implement for the built-in fonts. I'll keep this feature request open, in case you ever want to implement this at some point in the future. |
|
Thanks for clarifying again. Then essentially what you are asking for is an extremely narrow special case of FontDot, because you want the dots to disappear. Solving that in another way would make a lot more sense, because of all the built-in font characters, space is about the only one that would make sense to be used. |
|
What I could imagine is having different sets of preset images to fill the pattern with:
This could be achieved much more easily than adjusting the FontDot option in any way for the built-in fonts. |
|
Sure, that's a nice idea. I like the idea of zeros, but it doesn't make sense to have zeros in the note column. So maybe the presets could be better like this:
it would also be nice to have those zeros options for custom fonts as well. Maybe by having two separate |
|
Uhm, I think we can use the existing FontDot setting even for builtin fonts: |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2022-08-12 17:02 | cs127 | New Issue | |
2022-08-12 19:24 | Saga Musix | Note Added: 0005265 | |
2022-08-12 21:11 | cs127 | Note Added: 0005267 | |
2022-08-12 21:20 | Saga Musix | Note Added: 0005268 | |
2022-08-13 02:17 | cs127 | Note Added: 0005269 | |
2022-08-13 10:57 | cs127 | Note Added: 0005270 | |
2022-08-13 12:36 | Saga Musix | Note Added: 0005271 | |
2022-08-13 15:36 | Saga Musix | Note Added: 0005272 | |
2022-08-14 11:19 | cs127 | Note Added: 0005273 | |
2022-08-14 14:14 | manx | Note Added: 0005279 | |
2022-08-14 14:14 | manx | Relationship added | related to 0001114 |