View Issue Details

IDProjectCategoryView StatusLast Update
0001615OpenMPTGeneralpublic2022-09-06 15:52
Reportermarsimeau Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.30.05.00 / libopenmpt 0.6.4 (upgrade first) 
Target VersionOpenMPT 1.31 / libopenmpt 0.7 (goals) 
Summary0001615: Do not restore deleted keyboard actions
Description

Deleted keyboard actions are being restored upon launch.

Steps To Reproduce
  1. Go to View > Setup > Keyboard
  2. Select an action and click "Delete" in "Key setup for selected commands"
  3. Restart OpenMPT
  4. Go to back to View > Setup > Keyboard
  5. Check the "Key:" field for the same action.

Issue: the key field is filled again as if it was never deleted.

Additional Information

Key changes are kept, only delete has this issue.

Tested on both the installer version and the portable version.

I often accidentally hit the CTRL + W shortcut (File/Close) when transposing notes (CTRL+Q) and wanted to unset this shortcut to prevent accidental lost of progress.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2022-07-10 18:52

administrator   ~0005253

Yes, OpenMPT by default restores all default key bindings, as that is currently the only way new default key bindings can be added to existing keymaps (so that long-term users can still automatically use of newly added features). To work around that, you have to assign the deleted shortcut (in this case Ctrl+W) to the global "Dummy Shortcut". If you do that, no default shortcuts using Ctrl+W are added back automatically anymore, and the Dummy Shortcut itself does nothing.

This is not optimal and will improve the in the future hopefully.

marsimeau

marsimeau

2022-07-10 22:58

reporter   ~0005254

Did not know about this, thank you. This is good enough for my needs.

Saga Musix

Saga Musix

2022-09-06 15:52

administrator   ~0005302

As of r17824, shortcuts from the default keymap will only be added to the user keymap if they were introduced in a later version than the keymap was saved with. I don't think I will backport this change to OpenMPT 1.30, so it will only be active from OpenMPT 1.31 onwards. This will also make the Dummy Shortcut obsolete.

Issue History

Date Modified Username Field Change
2022-07-10 15:15 marsimeau New Issue
2022-07-10 15:17 marsimeau Additional Information Updated
2022-07-10 18:52 Saga Musix Note Added: 0005253
2022-07-10 18:53 Saga Musix Status new => feedback
2022-07-10 22:58 marsimeau Note Added: 0005254
2022-07-10 22:58 marsimeau Status feedback => new
2022-09-06 15:01 Saga Musix Assigned To => Saga Musix
2022-09-06 15:01 Saga Musix Status new => assigned
2022-09-06 15:02 Saga Musix Target Version => OpenMPT 1.31 / libopenmpt 0.7 (goals)
2022-09-06 15:02 Saga Musix Summary Deleted keyboard actions are being restored upon launch => Do not restore deleted keyboard actions
2022-09-06 15:52 Saga Musix Note Added: 0005302
2022-09-06 15:52 Saga Musix Status assigned => resolved
2022-09-06 15:52 Saga Musix Resolution open => fixed