View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001615||OpenMPT||General||public||2022-07-10 15:15||2022-09-06 15:52|
|Reporter||marsimeau||Assigned To||Saga Musix|
|Product Version||OpenMPT 1.30.05.00 / libopenmpt 0.6.4 (upgrade first)|
|Target Version||OpenMPT 1.31 / libopenmpt 0.7 (goals)|
|Summary||0001615: Do not restore deleted keyboard actions|
Deleted keyboard actions are being restored upon launch.
|Steps To Reproduce|
Issue: the key field is filled again as if it was never deleted.
Key changes are kept, only delete has this issue.
Tested on both the installer version and the portable version.
I often accidentally hit the CTRL + W shortcut (File/Close) when transposing notes (CTRL+Q) and wanted to unset this shortcut to prevent accidental lost of progress.
|Tags||No tags attached.|
|Has the bug occurred in previous versions?|
|Tested code revision (in case you know it)|
Yes, OpenMPT by default restores all default key bindings, as that is currently the only way new default key bindings can be added to existing keymaps (so that long-term users can still automatically use of newly added features). To work around that, you have to assign the deleted shortcut (in this case Ctrl+W) to the global "Dummy Shortcut". If you do that, no default shortcuts using Ctrl+W are added back automatically anymore, and the Dummy Shortcut itself does nothing.
This is not optimal and will improve the in the future hopefully.
Did not know about this, thank you. This is good enough for my needs.
As of r17824, shortcuts from the default keymap will only be added to the user keymap if they were introduced in a later version than the keymap was saved with. I don't think I will backport this change to OpenMPT 1.30, so it will only be active from OpenMPT 1.31 onwards. This will also make the Dummy Shortcut obsolete.
|2022-07-10 15:15||marsimeau||New Issue|
|2022-07-10 15:17||marsimeau||Additional Information Updated|
|2022-07-10 18:52||Saga Musix||Note Added: 0005253|
|2022-07-10 18:53||Saga Musix||Status||new => feedback|
|2022-07-10 22:58||marsimeau||Note Added: 0005254|
|2022-07-10 22:58||marsimeau||Status||feedback => new|
|2022-09-06 15:01||Saga Musix||Assigned To||=> Saga Musix|
|2022-09-06 15:01||Saga Musix||Status||new => assigned|
|2022-09-06 15:02||Saga Musix||Target Version||=> OpenMPT 1.31 / libopenmpt 0.7 (goals)|
|2022-09-06 15:02||Saga Musix||Summary||Deleted keyboard actions are being restored upon launch => Do not restore deleted keyboard actions|
|2022-09-06 15:52||Saga Musix||Note Added: 0005302|
|2022-09-06 15:52||Saga Musix||Status||assigned => resolved|
|2022-09-06 15:52||Saga Musix||Resolution||open => fixed|