View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000157OpenMPTGeneralpublic2011-07-31 08:292011-07-31 21:56
Reporterchristofori Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.20.00.* (old testing) 
Target VersionOpenMPT 1.20.01.00 (upgrade first)Fixed in VersionOpenMPT 1.20.01.00 (upgrade first) 
Summary0000157: Amplify Notes doesn't effect last channel in selection range
Description

When using the standard(?) keymap: CTRL-M to change the volumes of selected pattern data, the only time the function still works seems to be if the instrument(s) involved have samples mapped to the notes selected.

Steps To Reproduce
  • Open 1.20.00 MPT, click new file.
  • Import/set up some samples/instruments [[unless you're using a template already (* WOOT! Still looking at that some more before posting feedback, relabs!)]]
  • Make sure you've got one instrument that's got a full sample map, and one that either doesn't have any mapped (fe: using a VST instrument instead of sampled one) or has SOME samples mapped but not all (fe: I use 'drum kits' I've created, one's actually available on my site if you want to get it to test with for ease of discussion: http://www.christofori.net/index.php?info=contents/instruments.html - look for the one with the long description, should be GigaHall I think. IF you use this you'll notice in the instrument names the octave numbers that correspond to the different drum types; from C chromatically upward you'll get louder to softer dynamic levels respectively)
  • Enter a few notes into any column. Be sure to use the fully sample-mapped instrument in a column, and your VST instrument in another adjacent column (for ease of example)
  • Select the columns, or select only the notes entered
  • Open the Amplify dialog (via your current/default keymap)
  • Enter any values, check any boxes
  • Observe that your sample-mapped note data in the pattern has received amplification, while the VST values did not
Additional Information

Depending on one's velocity and volume handling (I have tried multiple combinations, and it appears to be related to the sample map rather than these settings..) it should still indeed be possible to modify the pattern notes' volumes via the amplify dialog.. unless I missed something.. :P

TagsNo tags attached.
Has the bug occurred in previous versions?No; only in current testing 1.20.00.00
Tested code revision (in case you know it)

Activities

christofori

christofori

2011-07-31 08:39

reporter   ~0000275

Hold on... I got it to work for one that doesn't have samples mapped now, but it's still inconsistant for me. I haven't switched the song I'm working on into a smaller file nor finished making my templates yet; I'm beginning to wonder if it's more related to the size of the file instead.. I'll do a bit further testing and report back.
christofori

christofori

2011-07-31 08:56

reporter   ~0000276

Nah, it's simpler than all that -- if you highlite only one column, there is no effect. If you highlite MULTIPLE columns however, the rightmost one is not effected while the others are. :) This one had me going crazy for a moment until I realized what it was..!
Saga Musix

Saga Musix

2011-07-31 11:38

administrator   ~0000277

This seems to be an unwanted side effect of some refactoring that happened in revision 927; will fix ASAP.
christofori

christofori

2011-07-31 12:41

reporter   ~0000278

No prob -- I figured it wasn't intended.. though I have also just discovered that interpolation is rather randomly affected as well. FE if you go to any channel and enter in the first row:

PC 2 022 999

Then go down to the 24th row (I've not been able to test much more than this that guarantees you'll see the issue) and enter:

PC 2 022 555

Try to interpolate them.. it 'fills down' 999's :)
Saga Musix

Saga Musix

2011-07-31 12:44

administrator   ~0000280

Last edited: 2011-07-31 12:53

It is not affected by the same bug, but it's broken indeed. Seems like relabs' refactoring activies broke it this time, not mine. :>
Saga Musix

Saga Musix

2011-07-31 13:16

administrator   ~0000281

Revisions 949 / 950 should fix those issues; please confirm that http://sagagames.de/stuff/mptrack.exe works as expected.
rakib

rakib

2011-07-31 16:31

reporter   ~0000282

Must say it was fast bug fixing. Great work!
christofori

christofori

2011-07-31 21:54

reporter   ~0000283

Confirmed; both bugs squashed. ;)

So...... you're BOTH to blame then..!! That is, I blame you both for working very hard and making MUCH progress this weekend! THANK YOU! (relabs -- I'm truly going to get you your template feedback soon! This took precedance only as it was a bug and that was a feature request)

Issue History

Date Modified Username Field Change
2011-07-31 08:29 christofori New Issue
2011-07-31 08:39 christofori Note Added: 0000275
2011-07-31 08:56 christofori Note Added: 0000276
2011-07-31 11:38 Saga Musix Note Added: 0000277
2011-07-31 11:38 Saga Musix Assigned To => Saga Musix
2011-07-31 11:38 Saga Musix Status new => assigned
2011-07-31 11:44 Saga Musix Summary Amplify Notes doesn't effect notes without samples mapped to them => Amplify Notes doesn't effect last channel in selection range
2011-07-31 12:41 christofori Note Added: 0000278
2011-07-31 12:44 Saga Musix Note Added: 0000280
2011-07-31 12:53 Saga Musix Note Edited: 0000280
2011-07-31 13:16 Saga Musix Note Added: 0000281
2011-07-31 13:16 Saga Musix Status assigned => feedback
2011-07-31 13:16 Saga Musix Fixed in Version => OpenMPT 1.20.00.* (old testing)
2011-07-31 13:16 Saga Musix Target Version => OpenMPT 1.20.01.00 (upgrade first)
2011-07-31 16:31 rakib Note Added: 0000282
2011-07-31 21:54 christofori Note Added: 0000283
2011-07-31 21:54 christofori Status feedback => assigned
2011-07-31 21:56 Saga Musix Status assigned => resolved
2011-07-31 21:56 Saga Musix Resolution open => fixed