View Issue Details

IDProjectCategoryView StatusLast Update
0001552OpenMPTAudio I/Opublic2022-01-24 17:56
Reporter0x5066 Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.31.00.* (current testing) 
Target VersionOpenMPT 1.31 / libopenmpt 0.7 (goals)Fixed in VersionOpenMPT 1.31 / libopenmpt 0.7 (goals) 
Summary0001552: "No Interpolation" will make a 32 sample 50% square sound not like a 50% square
Description

Hi there,

as the summary describes, a 32 smp 50% square sample does not sound like a proper 50% square when the resampling mode is set to "No Interpolation", I believe this worked fine with 1.31.00.04 or 1.31.00.03.

Steps To Reproduce

Have a 32 smp long 50% square on hand and play around a bit, attached is a Super Mario Bros. Underground module that shows this issue perfectly.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)r16666

Activities

0x5066

0x5066

2022-01-23 20:16

reporter  

smb_underground.7z (10,459 bytes)
Saga Musix

Saga Musix

2022-01-23 22:32

administrator   ~0004999

Ah, oops, I recently enabled rounding in No Interpolation mode for OpenMPT 1.31, but in addition for that to work correctly I also need to turn on the loop wrap-around buffer I guess so that the rounding finds the right sample at the end of the loop. I will look into this.

Saga Musix

Saga Musix

2022-01-23 22:42

administrator   ~0005000

Please check if r16676 sounds better for you.

0x5066

0x5066

2022-01-24 16:28

reporter   ~0005001

Just got around to check, sounds just as great as before!
Thank you so much!

Issue History

Date Modified Username Field Change
2022-01-23 20:16 0x5066 New Issue
2022-01-23 20:16 0x5066 File Added: smb_underground.7z
2022-01-23 22:32 Saga Musix Note Added: 0004999
2022-01-23 22:32 Saga Musix Assigned To => Saga Musix
2022-01-23 22:32 Saga Musix Status new => assigned
2022-01-23 22:42 Saga Musix Note Added: 0005000
2022-01-23 22:42 Saga Musix Status assigned => feedback
2022-01-24 16:28 0x5066 Note Added: 0005001
2022-01-24 16:28 0x5066 Status feedback => assigned
2022-01-24 17:56 Saga Musix Status assigned => resolved
2022-01-24 17:56 Saga Musix Resolution open => fixed
2022-01-24 17:56 Saga Musix Fixed in Version => OpenMPT 1.31 / libopenmpt 0.7 (goals)
2022-01-24 17:56 Saga Musix Target Version => OpenMPT 1.31 / libopenmpt 0.7 (goals)