View Issue Details

IDProjectCategoryView StatusLast Update
0001545OpenMPTFile Format Supportpublic2022-01-09 14:59
ReporterLachesis Assigned ToSaga Musix  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first) 
Target VersionOpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upgrade first)Fixed in VersionOpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upgrade first) 
Summary0001545: Digital Symphony conversion for low tempos is incorrect.
Description

In the attached module, the effect 2F 0A0 in order 0 channel 4 at row 30 should set a fairly slow tempo. In OpenMPT this instead gets converted to the IT effect F14 Set Tempo +4 bpm.

In my pending libxmp patch I use the S3M BPM effect (in libxmp, tempos <0x20 are filtered in the S3M loader instead of in the effect handler):

    case 0x2f:  /* 2F xxx Set Tempo */
        if (parm) {
            parm = (parm + 4) >> 3; /* round to nearest */
            CLAMP(parm, XMP_MIN_BPM, 255);
            e->fxt = FX_S3M_BPM;
            e->fxp = parm;
        } else {
            e->fxt = 0;
        }
        break;
Steps To Reproduce

Play the attached module in OpenMPT. Its duration is about 12-13 seconds in the Digital Symphony demo, but in OpenMPT it plays for about 5 seconds.

TagsNo tags attached.
Has the bug occurred in previous versions?No (Digital Symphony loading didn't work in the prior version I had set up.)
Tested code revision (in case you know it)

Activities

Lachesis

Lachesis

2022-01-09 04:21

reporter  

plastic.dsym.zip (6,363 bytes)
Saga Musix

Saga Musix

2022-01-09 14:07

administrator   ~0004981

Fixed in r16473: libopenmpt supports low tempos properly, OpenMPT clamps them to 32.

Issue History

Date Modified Username Field Change
2022-01-09 04:21 Lachesis New Issue
2022-01-09 04:21 Lachesis File Added: plastic.dsym.zip
2022-01-09 14:07 Saga Musix Assigned To => Saga Musix
2022-01-09 14:07 Saga Musix Status new => assigned
2022-01-09 14:07 Saga Musix Note Added: 0004981
2022-01-09 14:59 Saga Musix Status assigned => resolved
2022-01-09 14:59 Saga Musix Resolution open => fixed
2022-01-09 14:59 Saga Musix Fixed in Version => OpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upgrade first)
2022-01-09 14:59 Saga Musix Target Version => OpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upgrade first)
2022-01-09 14:59 Saga Musix Description Updated