View Issue Details

IDProjectCategoryView StatusLast Update
0001540OpenMPTGeneralpublic2022-01-04 15:35
ReporterSaga Musix Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
Status newResolutionopen 
Product VersionOpenMPT 1.30.01.00 / libopenmpt 0.6.0 (current stable) 
Summary0001540: Phase out default cue points
Description

Continued from https://forum.openmpt.org/index.php?topic=6767.0

The default cue points (multiple of 2048 samples) mostly exist for historical reasons (that's how oxx worked before custom cue points could be set). However, the default cue points are probably not very useful for most users and clutter the interface, so we should consider not setting them for new modules.

This is not entirely trivial though:

  • We still need to set them when loading old modules that lack CUES chunks. Compatibility-exported modules should not matter in theory because they shouldn't contain this effect at all.
    • This may get tricky because we now need different "defaults" for modules that have no CUES chunk and when importing samples into the sample editor that don't have any cue points.
  • For backwards compatibility we should probably still treat the old defaults (2048, 4096, ...) the same way as before (i.e. don't write CUES chunk if sample uses old defaults, but do write a CUES chunk if a sample has no cue points at all). Note: We always need to write the complete set of 9 cue points because otherwise they will fall back to offset 0.
  • Possible optimization: Write no cue points if the sample is shorter than 2048 points and has no cue points
TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2022-01-04 15:17 Saga Musix New Issue
2022-01-04 15:35 Saga Musix Description Updated