View Issue Details

IDProjectCategoryView StatusLast Update
0001540OpenMPTGeneralpublic2022-01-29 22:43
ReporterSaga Musix Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Product VersionOpenMPT / libopenmpt 0.6.0 (upgrade first) 
Summary0001540: Phase out default cue points

Continued from

The default cue points (multiple of 2048 samples) mostly exist for historical reasons (that's how oxx worked before custom cue points could be set). However, the default cue points are probably not very useful for most users and clutter the interface, so we should consider not setting them for new modules.

This is not entirely trivial though:

  • We still need to set them when loading old modules that lack CUES chunks. Compatibility-exported modules should not matter in theory because they shouldn't contain this effect at all.
    • This may get tricky because we now need different "defaults" for modules that have no CUES chunk and when importing samples into the sample editor that don't have any cue points.
  • For backwards compatibility we should probably still treat the old defaults (2048, 4096, ...) the same way as before (i.e. don't write CUES chunk if sample uses old defaults, but do write a CUES chunk if a sample has no cue points at all). Note: We always need to write the complete set of 9 cue points because otherwise they will fall back to offset 0.
  • Possible optimization: Write no cue points if the sample is shorter than 2048 points and has no cue points
TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)


Saga Musix

Saga Musix

2022-01-29 22:43

administrator   ~0005026

As of r16753 the default cue points are no longer used for new samples. This is not quite perfect yet because for compatibility-exported ITs we still import cue points even though such files cannot contain the cue point volume column command. Maybe we can completely remove the cue points from those files during load time.

Issue History

Date Modified Username Field Change
2022-01-04 15:17 Saga Musix New Issue
2022-01-04 15:35 Saga Musix Description Updated
2022-01-29 22:43 Saga Musix Note Added: 0005026
2022-01-29 22:43 Saga Musix Assigned To => Saga Musix
2022-01-29 22:43 Saga Musix Status new => assigned