View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001536 | OpenMPT | User Interface | public | 2021-12-23 19:05 | 2021-12-25 21:49 |
Reporter | cs127 | Assigned To | Saga Musix | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | x64 | OS | Windows | OS Version | 10 |
Product Version | OpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first) | ||||
Target Version | OpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upgrade first) | Fixed in Version | OpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upgrade first) | ||
Summary | 0001536: Status bar displays parameters of 1.30 finetune commands incorrectly | ||||
Description | When a song is playing or paused, the status bar shows the parameter for finetune commands correctly, in relation to the instrument's pitch bend range. But when the song is stopped, it always shows it in the range [-128, 127] regardless of the instrument's pitch bend range. Note: I have not tested this with Parameter Extension commands ( | ||||
Steps To Reproduce |
| ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | No, because the affected feature itself didn't exist. | ||||
Tested code revision (in case you know it) | 16290 | ||||
The statusbar always uses "live" playback data. I guess there could be a special case if the finetune command is right next to an instrument number, but in all other cases it won't be possible to show the "correct" finetune range. |
|
Oh right. Well then, I suggest adding that special case, it would still be an improvement even if it doesn't cover all cases. |
|
It would be a good idea, yes - the code that is responsible for displaying effects isn't aware of the other cell entries like the instrument number. This might be tricky to implement. |
|
Another idea: how about displaying it without the unit when the song is stopped? So for example:
Additionally, the fact that the "unit" is displayed as I suggest changing the name to something like or maybe converting the value to cents when displaying it (e.g. |
|
It's the same issue - the code simply doesn't know whether the song is playing or not. It receives the information about the current channel state but that doesn't contain any information on whether playback is running or not. That would be more difficult to figure out than the surrounding instrument information, probably. |
|
Managed to sneak some instrument information into the effect name formatting in r16338. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2021-12-23 19:05 | cs127 | New Issue | |
2021-12-23 19:06 | cs127 | Description Updated | |
2021-12-23 19:09 | Saga Musix | Note Added: 0004959 | |
2021-12-23 19:22 | cs127 | Note Added: 0004961 | |
2021-12-23 19:35 | Saga Musix | Note Added: 0004963 | |
2021-12-23 20:02 | cs127 | Note Added: 0004964 | |
2021-12-25 20:29 | Saga Musix | Note Added: 0004974 | |
2021-12-25 20:45 | Saga Musix | Assigned To | => Saga Musix |
2021-12-25 20:45 | Saga Musix | Status | new => assigned |
2021-12-25 21:49 | Saga Musix | Note Added: 0004975 | |
2021-12-25 21:49 | Saga Musix | Status | assigned => resolved |
2021-12-25 21:49 | Saga Musix | Resolution | open => fixed |
2021-12-25 21:49 | Saga Musix | Fixed in Version | => OpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upgrade first) |
2021-12-25 21:49 | Saga Musix | Target Version | => OpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upgrade first) |