View Issue Details

IDProjectCategoryView StatusLast Update
0001536OpenMPTUser Interfacepublic2021-12-25 21:49
Reportercs127 Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.30.01.00 / libopenmpt 0.6.0 (current stable) 
Target VersionOpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upcoming stable)Fixed in VersionOpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upcoming stable) 
Summary0001536: Status bar displays parameters of 1.30 finetune commands incorrectly
Description

When a song is playing or paused, the status bar shows the parameter for finetune commands correctly, in relation to the instrument's pitch bend range.

But when the song is stopped, it always shows it in the range [-128, 127] regardless of the instrument's pitch bend range.

Note: I have not tested this with Parameter Extension commands (#), so I don't know how this issue occurs if those are also used.

Steps To Reproduce
  1. Make an instrument with a pitchbend value other than 1.
  2. Place a note with that instrument in the pattern.
  3. Place a 1.30 finetune command (+ or *) in the same channel and same row.
  4. Move the pattern editor cursor to the finetune command.
  5. Notice how the status bar shows the parameter incorrectly when the song is stopped, and correctly when the song is paused.
TagsNo tags attached.
Has the bug occurred in previous versions?No, because the affected feature itself didn't exist.
Tested code revision (in case you know it)16290

Activities

Saga Musix

Saga Musix

2021-12-23 19:09

administrator   ~0004959

The statusbar always uses "live" playback data. I guess there could be a special case if the finetune command is right next to an instrument number, but in all other cases it won't be possible to show the "correct" finetune range.

cs127

cs127

2021-12-23 19:22

reporter   ~0004961

Oh right. Well then, I suggest adding that special case, it would still be an improvement even if it doesn't cover all cases.

Saga Musix

Saga Musix

2021-12-23 19:35

administrator   ~0004963

It would be a good idea, yes - the code that is responsible for displaying effects isn't aware of the other cell entries like the instrument number. This might be tricky to implement.

cs127

cs127

2021-12-23 20:02

reporter   ~0004964

Another idea: how about displaying it without the unit when the song is stopped?

So for example:

  • PB range = 1, Song is playing/paused: -128 cents ~ 127 cents
  • PB range = 2, Song is playing/paused: -256 cents ~ 254 cents
  • PB range = any, Song is stopped: -128 ~ 127

Additionally, the fact that the "unit" is displayed as cents can be a bit misleading; people might confuse it with 1/100th of a semitone when it's actually 1/128th.

I suggest changing the name to something like /128 semitones (e.g. +C0 becomes 64/128 semitones),

or maybe converting the value to cents when displaying it (e.g. +C0 becomes 50 cents or 0.5 semitones), or whatever you think that makes more sense.

Saga Musix

Saga Musix

2021-12-25 20:29

administrator   ~0004974

It's the same issue - the code simply doesn't know whether the song is playing or not. It receives the information about the current channel state but that doesn't contain any information on whether playback is running or not. That would be more difficult to figure out than the surrounding instrument information, probably.

Saga Musix

Saga Musix

2021-12-25 21:49

administrator   ~0004975

Managed to sneak some instrument information into the effect name formatting in r16338.

Issue History

Date Modified Username Field Change
2021-12-23 19:05 cs127 New Issue
2021-12-23 19:06 cs127 Description Updated
2021-12-23 19:09 Saga Musix Note Added: 0004959
2021-12-23 19:22 cs127 Note Added: 0004961
2021-12-23 19:35 Saga Musix Note Added: 0004963
2021-12-23 20:02 cs127 Note Added: 0004964
2021-12-25 20:29 Saga Musix Note Added: 0004974
2021-12-25 20:45 Saga Musix Assigned To => Saga Musix
2021-12-25 20:45 Saga Musix Status new => assigned
2021-12-25 21:49 Saga Musix Note Added: 0004975
2021-12-25 21:49 Saga Musix Status assigned => resolved
2021-12-25 21:49 Saga Musix Resolution open => fixed
2021-12-25 21:49 Saga Musix Fixed in Version => OpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upcoming stable)
2021-12-25 21:49 Saga Musix Target Version => OpenMPT 1.30.02.00 / libopenmpt 0.6.1 (upcoming stable)