0001529: Parameter Editor writes wrong Effect Type

ID	Project	Category	View Status	Date Submitted	Last Update

0001529	OpenMPT	General	public	2021-12-17 01:45	2021-12-17 20:59

Reporter	Polaris911	Assigned To	Saga Musix
Priority	normal	Severity	minor	Reproducibility	always
Status	assigned	Resolution	open
Product Version	OpenMPT 1.29.11.00 / libopenmpt 0.5.10 (upgrade first)

Summary	0001529: Parameter Editor writes wrong Effect Type
Description	This is a bug that occurs if you open the Parameter Editor (ALT + B) and edit the values on a PCs event. If you stop song, and select a different section of parameters to edit, press ALT + B to refresh, the new nodes show up in the Parameter Editor. But when you draw on the editor, it draws the previous effect type. I made a video clip to demonstrate this: https://dreamsneverdie.com/videos/openmpt.mp4 (30 MB) In my video, at 0:25 and again at 0:35, when I draw new nodes on the Parameter Editor, it writes Effect Type 002 from Channel 28 instead of 000 which would match the other effect type in the selected column. At 0:41, when I close the parameter editor window, then select rows and re-open, NOW it will write the correct effect type value (000).
Tags	No tags attached.

Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Saga Musix 2021-12-17 20:56 administrator ~0004951	Right now, when the dialog is first opened OpenMPT remembers the parameters of the PC event and uses them for all subsequent events. We could change that to happen anytime the selection changes of course, but I think there's also a more fundamental question - should the plugin and parameter ID be changed at all for existing PC events? I feel like there's no right or wrong here (both can be valid use cases) but I'm leaning towards: don't change the plugin and parameter ID of existing PC events, but when inserting a new PC event, use the plugin and parameter ID from the last modified PC event.

Date Modified	Username	Field	Change
2021-12-17 01:45	Polaris911	New Issue
2021-12-17 20:56	Saga Musix	Note Added: 0004951
2021-12-17 20:59	Saga Musix	Assigned To	=> Saga Musix
2021-12-17 20:59	Saga Musix	Status	new => assigned