0001525: Sign the uninstaller as well

ID	Project	Category	View Status	Date Submitted	Last Update

0001525	OpenMPT	Installer and Update	public	2021-12-08 21:52	2024-10-10 08:17

Reporter	Saga Musix	Assigned To	Saga Musix
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	resolved	Resolution	fixed
Target Version	OpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first)	Fixed in Version	OpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first)

Summary	0001525: Sign the uninstaller as well
Description	By letting InnoSetup do codesigning on its own, we can also codesign the uninstaller. This is slightly more convoluted than what we currently do. Rough outline of required changes: Have a proxy batch file that gathers all the requiredp parameters for signtool.exe Call this batch file from `sign_openmpt_executables.cmd` instead of the signtool directly Add `/Ssigntool=path_to_proxy_batch_file $f` to InnoSetup invocation Add `--sign` parameter to `build_openmpt_release_packages_multiarch.py` Pass this `--sign` parameter in `build_openmpt_release_packages_multiarch.cmd` Pass whatever is required for the former step in `build_openmpt_release_manual.cmd`
Tags	No tags attached.

Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Date Modified	Username	Field	Change
2021-12-08 21:52	Saga Musix	New Issue
2021-12-08 21:52	Saga Musix	Status	new => assigned
2021-12-08 21:52	Saga Musix	Assigned To	=> Saga Musix
2021-12-18 21:18	Saga Musix	Note Added: 0004956
2021-12-18 21:18	Saga Musix	Status	assigned => resolved
2021-12-18 21:18	Saga Musix	Resolution	open => fixed
2021-12-18 21:18	Saga Musix	Fixed in Version	=> OpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first)
2024-10-10 08:17	manx	Category	General => Installer and Update

Saga Musix 2021-12-18 21:18 administrator ~0004956	Done in r16186.