View Issue Details

IDProjectCategoryView StatusLast Update
0001510OpenMPTPlayer input plugins (xmp-openmpt, in_openmpt)public2021-10-03 13:26
Reporterrelabs Assigned ToSaga Musix  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.29.12.00 / libopenmpt 0.5.11 (upgrade first) 
Target VersionOpenMPT 1.29.13.00 / libopenmpt 0.5.12 (current stable)Fixed in VersionOpenMPT 1.29.13.00 / libopenmpt 0.5.12 (current stable) 
Summary0001510: in_openmpt (Winamp plugin): Opening info dialog from "View file info..." overwrites media library metadata fields
Description

Opening "View file info..." overwrites metadata fields for selected file as if user had chosen "Read metadata for selected items". Given the wide variety of metadata format in module, it is quite common that at least some metadata needs to be set manually so this behaviour can easily cause user effort to be undone.

Steps To Reproduce
  1. Import module file to Winamp (5.66) media library
  2. Edit and save metadata (e.g. from context menu "Edit metadata for selection")
  3. Choose "View file info..." from context menu. After closing the dialog, edit made in step 2 is replaced by automatic metadata content.
Additional Information

Simply changing
return 0;
to
return INFOBOX_UNCHANGED;

in in_openmpt.cpp / int infobox() seemed to fix the issue. After this change it is still possible to read metadata using "Read metadata for selected items" functionality.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2021-10-03 13:26

administrator   ~0004886

That change looks sensible, commited as of r15745.

Issue History

Date Modified Username Field Change
2021-10-03 13:17 relabs New Issue
2021-10-03 13:18 relabs Additional Information Updated
2021-10-03 13:25 Saga Musix Assigned To => Saga Musix
2021-10-03 13:25 Saga Musix Status new => assigned
2021-10-03 13:26 Saga Musix Note Added: 0004886
2021-10-03 13:26 Saga Musix Status assigned => resolved
2021-10-03 13:26 Saga Musix Resolution open => fixed
2021-10-03 13:26 Saga Musix Fixed in Version => OpenMPT 1.29.13.00 / libopenmpt 0.5.12 (current stable)
2021-10-03 13:26 Saga Musix Target Version => OpenMPT 1.29.13.00 / libopenmpt 0.5.12 (current stable)