View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000151OpenMPTGeneralpublic2011-07-02 21:572011-07-04 13:25
Reporterchristofori Assigned To 
PrioritynoneSeveritytrivialReproducibilityunable to reproduce
Status closedResolutionno change required 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.19.02.* (old testing) 
Summary0000151: Cleanup Instruments 'misses' instrument numbers used in PCEs
Description

Running Cleanup Instruments and selecting to remove/rearrange instruments will see PCEs with a plugin number and think instead it is still a call for the instrument of the same number. Thus the instrument which isn't actually used anywhere in the cleaned up sequence is NOT removed.. if the instrument did not exist prior to running cleanup, my 'gut' tells me it'd throw an exception and possibly crash.. Will attempt to test soon...

Steps To Reproduce

Take a song, pick an unused instrument number. Ensure a plugin is assigned to the plugin slot with the SAME number. Select to clean up the instruments; the instrument that isn't used in the global pattern data is still in the 'cleaned up' module.. even though the PCE is the actual data containing the similar number.

Additional Information

Will change priority/severity accordingly upon testing completion..

TagsNo tags attached.
Has the bug occurred in previous versions?All versions containing PCEs; ~v1.17.3.02 and forward (?)
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2011-07-02 23:39

administrator   ~0000242

I can't reproduce that. I have one pattern:

ModPlug Tracker MPT
|PC 02000000
|C-503......

After cleaning up, only one instrument is left, and the pattern looks like

ModPlug Tracker MPT
|PC 02000000
|C-501......

So nothing's gone wrong?
christofori

christofori

2011-07-03 23:06

reporter   ~0000244

hmmmmmm, now I can't duplicate it either... I'll see if I can figure out what was causing this; I have to find the file I was using at the time and ensure it didn't have any unused patterns (I'm beginning to suspect that it did...)
christofori

christofori

2011-07-04 08:34

reporter   ~0000245

I can't duplicate this either now, even in the same file. That day I'd had several VSTi-related crashes and hadn't restarted the OS yet; perhaps something leftover in memory made a twilight zone for me.. dunno. But this apparently isn't an issue after all.. Cleanup seems to work as designed no matter what kind of combo I throw at it, now.

Issue History

Date Modified Username Field Change
2011-07-02 21:57 christofori New Issue
2011-07-02 23:39 Saga Musix Note Added: 0000242
2011-07-03 23:06 christofori Note Added: 0000244
2011-07-04 08:34 christofori Note Added: 0000245
2011-07-04 08:36 christofori Priority normal => none
2011-07-04 08:36 christofori Severity minor => trivial
2011-07-04 08:36 christofori Reproducibility always => unable to reproduce
2011-07-04 08:36 christofori Resolution open => no change required
2011-07-04 13:25 Saga Musix Status new => closed