View Issue Details

IDProjectCategoryView StatusLast Update
0000150OpenMPTFeature Requestpublic2011-07-02 22:29
Reporterchristofori Assigned To 
PrioritynormalSeveritytweakReproducibilityN/A
Status newResolutionopen 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.19.02.* (old testing) 
Summary0000150: Allow user control for how instruments are determined to be 'used'
Description

Currently, an instrument is deemed 'in use' if it is in use in any pattern anywhere (any sequence or even unused patterns). In the event one is used in a pattern not in the ordlist, a blank/silent file is created wasting time and space when it need not be created (after all, the pattern using the inst. isn't in the song/sequence being exported; how then is the length of time it's exported WAV file takes determined to be the length of the sequence being exported?!). Allow the user control via determining if they want:

  • Default (export all instruments used in global pattern data)
  • Sequenced (only export instruments used in patterns of the current sequence)
  • Pattern Only (only export instruments used in the currently selected pattern)
Steps To Reproduce

n/a. Re-wrote request as it seems we ended up both having the same idea in discussion... just phrased/understood each other completely differently..

Additional Information

Should be quite an easy mod since the code to check in-use instruments should already exist via the cleanup->instruments ("Remove unused") functionality.. ;) but check the bug ticket for PCEs interfering with the export as well, please.

TagsNo tags attached.
Has the bug occurred in previous versions?Indeed.
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2011-07-02 11:37

administrator   ~0000234

It would be pretty stupid to make this not optional. Why would one not want to enable it, if this option existed? :)

Saga Musix

Saga Musix

2011-07-02 11:45

administrator   ~0000235

Also, I just checked again because I thought that I have actually implemented this - if an instrument is not used, it is not rendered to a file. The check is done globally, i.e. for all patterns in a file, so if you have a reference to an instrument in a pattern that does not appear in the order list, it will be rendered nevertheless.

christofori

christofori

2011-07-02 13:10

reporter   ~0000236

Last edited: 2011-07-02 13:13

I think you mean '..to make this optional..' above..?

Okay, 99% completed then in my eye; how about instead of how requested above, the sub-option be changed to a drop-down/selection box with the following choices:

  • Current sequence
  • Current pattern
  • All (global patterndata)

... or the like..? Of course the 'current sequence' option would only be viable to module types supporting sequences.. Anyone using a file as a project, or using actual projects as templates or whatnot, would hate for this to FORCE a global check... ;)

Saga Musix

Saga Musix

2011-07-02 13:12

administrator   ~0000237

Again: Why would you wants this to be optional? If the sample is not used in the exported sequence, you will get a nice file with digital silence. I'd rather try to spot unused instrument in only the patterns that are actually exported, rather than asking what to do with them.

christofori

christofori

2011-07-02 13:15

reporter   ~0000238

Last edited: 2011-07-02 15:02

Edited my response... you are too quick..!

... and FE current sequence I'm working on has 25 instruments not in use in it's patterns, though they ARE in use in other sequences/patterns......... why would I want to sit through the creation of 25 extra 5-someodd-minute length wav files?!
.... here's another file I work in with 78 defined instruments, in one idea sequence FE there are only 15 in use... heaven forbid I'd ever want to export it's instruments under the current operation (I sure as heck wouldn't do so using 'slow render'...)

and/or: why save-as, a copy of the file if only to cleanup unused instruments? Seems the program's already got functionality built-in; shouldn't it be the user's choice HOW said functionality works? Much of the rest of the creative aspects possible within the program are.

The point: not everyone sees it (nor uses the program) as you do (or would expect, perhaps..) ;)

(ok, done editing..)

christofori

christofori

2011-07-02 22:04

reporter   ~0000239

Clarified the nature of the actual request to make more clear and consice.

christofori

christofori

2011-07-02 22:19

reporter   ~0000240

SMALL note, not worth adding a new ticket/issue for... (I promise I'm not searching for extra work needing to be done; I'm just thorough..)

Issue:
Instruments containing extended ASCII in name not exported with proper char in filename

Steps to Reproduce:
Name an instrument so it contains the ö (U+00F6) character. Export it. It's changed on my platform to that of a longhand division sign: ÷ (U+00F7)

=Suggestion:
=Character map appears to be off by 1 character value somewhere... (trying to be as helpful as possible.. to save some time I hope..) I didn't test other instrument names using ext. ascii.... too busy finding other issues at the moment.. :(

christofori

christofori

2011-07-02 22:29

reporter   ~0000241

Correction: exported name is correct in GUI but incorrect when viewing from command prompt only... Could be a windoze problem.

Issue History

Date Modified Username Field Change
2011-07-02 11:00 christofori New Issue
2011-07-02 11:37 Saga Musix Note Added: 0000234
2011-07-02 11:45 Saga Musix Note Added: 0000235
2011-07-02 13:10 christofori Note Added: 0000236
2011-07-02 13:12 Saga Musix Note Added: 0000237
2011-07-02 13:13 christofori Note Edited: 0000236
2011-07-02 13:15 christofori Note Added: 0000238
2011-07-02 13:25 christofori Note Edited: 0000238
2011-07-02 13:27 christofori Note Edited: 0000238
2011-07-02 15:02 christofori Note Edited: 0000238
2011-07-02 22:04 christofori Note Added: 0000239
2011-07-02 22:04 christofori Summary Allow to only export used instruments => Allow user control for how instruments are determined to be 'used'
2011-07-02 22:04 christofori Description Updated
2011-07-02 22:04 christofori Steps to Reproduce Updated
2011-07-02 22:04 christofori Additional Information Updated
2011-07-02 22:19 christofori Note Added: 0000240
2011-07-02 22:29 christofori Note Added: 0000241